Page MenuHomePhabricator
Differential D5305

[Nix] Add rust-up to dev shell
ClosedPublic
Actions

Authored by • jon on Oct 5 2022, 11:20 AM.
Tags
None
Referenced Files
F3492808: D5305.diff
Thu, Dec 19, 1:41 AM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:03 PM
Unknown Object (File)
Fri, Nov 22, 8:57 AM
Unknown Object (File)
Fri, Nov 22, 8:57 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• abosh
atul
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMdcd62fe19c58: [Nix] Add rust-up to dev shell
Summary

Add rust-up to dev shell.

Enables addition of toolchains for iOS and others

https://linear.app/comm/issue/ENG-1939

Test Plan
nix develop
which rustup # points to nix store

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/add-rustup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Oct 5 2022, 11:20 AM
Owners added a reviewer: Restricted Owners Package.Oct 5 2022, 11:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 5 2022, 11:20 AM
• jon edited the summary of this revision. (Show Details)Oct 5 2022, 11:21 AM
Harbormaster completed remote builds in B12640: Diff 17370.Oct 5 2022, 11:29 AM
• jon requested review of this revision.Oct 5 2022, 11:29 AM
atul accepted this revision.Oct 5 2022, 11:58 AM
$ which rustup
/nix/store/2jhm63j6i1fg3fxcz4zbcfzwsgqf99rb-rustup-1.25.1/bin/rustup
atul accepted this revision.Oct 5 2022, 12:28 PM
This revision is now accepted and ready to land.Oct 5 2022, 12:28 PM
ashoat added a comment.Oct 10 2022, 3:34 PM

Should we land this?

• jon added a comment.Oct 10 2022, 3:38 PM

Don't see why not.

People may need to do a cargo clean if they have artifacts from a different rustc version.

ashoat added a comment.Oct 10 2022, 3:50 PM

Sorry realizing my last comment could be interpreted as either skepticism or encouragement... meant the latter!

• jon added a comment.Oct 10 2022, 4:01 PM

oh, a reminder that it's ready to land. Yea.

Closed by commit rCOMMdcd62fe19c58: [Nix] Add rust-up to dev shell (authored by • jon). · Explain WhyOct 10 2022, 4:02 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMdcd62fe19c58: [Nix] Add rust-up to dev shell.

Revision Contents
Changeset List

PathSize
nix/
2 lines

Diff 17370

View Options

nix/dev-shell.nix

Loading...