Page MenuHomePhabricator

[Nix] Add rust-up to dev shell
ClosedPublic

Authored by jon on Oct 5 2022, 11:20 AM.
Tags
None
Referenced Files
F3492808: D5305.diff
Thu, Dec 19, 1:41 AM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:06 PM
Unknown Object (File)
Tue, Nov 26, 5:03 PM
Unknown Object (File)
Fri, Nov 22, 8:57 AM
Unknown Object (File)
Fri, Nov 22, 8:57 AM
Subscribers

Details

Reviewers
abosh
atul
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMdcd62fe19c58: [Nix] Add rust-up to dev shell
Summary

Add rust-up to dev shell.

Enables addition of toolchains for iOS and others

https://linear.app/comm/issue/ENG-1939

Test Plan
nix develop
which rustup # points to nix store

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 5 2022, 11:20 AM
$ which rustup
/nix/store/2jhm63j6i1fg3fxcz4zbcfzwsgqf99rb-rustup-1.25.1/bin/rustup
This revision is now accepted and ready to land.Oct 5 2022, 12:28 PM

Don't see why not.

People may need to do a cargo clean if they have artifacts from a different rustc version.

Sorry realizing my last comment could be interpreted as either skepticism or encouragement... meant the latter!

oh, a reminder that it's ready to land. Yea.

This revision was automatically updated to reflect the committed changes.