Paths

Table of Contentst

[web] replaced ThreadPicker with ThreadPicker modal
ClosedPublic
Actions

Authored by ginsu on Oct 7 2022, 6:58 PM.

Details

Reviewers

atul
rohan
• abosh

Commits

rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal

Summary

replaced ThreadPicker component with ThreadPickerModal component.

Depends on D5317 D5239 D5289 D5230

Linear Issue: ENG-1848

Design: ENG-1778

Test Plan

Please view the video to see how the new adding calendar event user flow works now:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 7 2022, 6:58 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 7 2022, 6:58 PM

ginsu edited the summary of this revision. (Show Details)Oct 7 2022, 7:01 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan, • abosh.

ginsu added parent revisions: D5317: [web] introduced thread-picker-modal.react, D5289: [web] refactored ThreadPicker from class based to functional, D5239: [web] implemented search feature for Thread Picker, D5230: [web] removed pagination logic from thread picker.

ginsu attached a referenced file: F193691: Screen Recording 2022-10-07 at 1.55.28 PM.mov. (Show Details)

Harbormaster completed remote builds in B12675: Diff 17419.Oct 7 2022, 7:09 PM

ginsu requested review of this revision.Oct 7 2022, 7:09 PM

Looks great!

This revision is now accepted and ready to land.Oct 7 2022, 8:13 PM

Closed by commit rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal. · Explain WhyOct 7 2022, 8:52 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal.

Revision Contents
Changeset List

Path

Size

web/

calendar/

day.react.js

44 lines

thread-picker.css

thread-picker.react.js

Diff 17427

View Options

web/calendar/day.react.js

View Options

web/calendar/thread-picker.css

View Options

web/calendar/thread-picker.react.js

[web] replaced ThreadPicker with ThreadPicker modalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17427

web/calendar/day.react.js

web/calendar/thread-picker.css

web/calendar/thread-picker.react.js

[web] replaced ThreadPicker with ThreadPicker modal
ClosedPublic
Actions

Revision Contents
Changeset List