Page MenuHomePhabricator
Differential D5318

[web] replaced ThreadPicker with ThreadPicker modal
ClosedPublic
Actions

Authored by ginsu on Oct 7 2022, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 1:35 AM
Unknown Object (File)
Mon, Apr 8, 1:35 AM
Unknown Object (File)
Mon, Apr 8, 1:34 AM
Unknown Object (File)
Mon, Apr 8, 1:15 AM
Unknown Object (File)
Mar 28 2024, 5:24 AM
Unknown Object (File)
Mar 25 2024, 4:51 AM
Unknown Object (File)
Mar 25 2024, 4:51 AM
Unknown Object (File)
Mar 25 2024, 4:51 AM
View All 65 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
rohan
• abosh
Commits
rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal
Summary

replaced ThreadPicker component with ThreadPickerModal component.

Depends on D5317 D5239 D5289 D5230

Linear Issue: ENG-1848

Design: ENG-1778

Test Plan

Please view the video to see how the new adding calendar event user flow works now:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 7 2022, 11:58 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 7 2022, 11:58 AM
ginsu edited the summary of this revision. (Show Details)Oct 7 2022, 12:01 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, • abosh.
ginsu added parent revisions: D5317: [web] introduced thread-picker-modal.react, D5289: [web] refactored ThreadPicker from class based to functional, D5239: [web] implemented search feature for Thread Picker, D5230: [web] removed pagination logic from thread picker.
ginsu attached a referenced file: F193691: Screen Recording 2022-10-07 at 1.55.28 PM.mov. (Show Details)
Harbormaster completed remote builds in B12675: Diff 17419.Oct 7 2022, 12:09 PM
ginsu requested review of this revision.Oct 7 2022, 12:09 PM
atul accepted this revision.Oct 7 2022, 1:13 PM

Looks great!

This revision is now accepted and ready to land.Oct 7 2022, 1:13 PM
Closed by commit rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal (authored by ginsu). · Explain WhyOct 7 2022, 1:52 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMbdc0254ad0d6: [web] replaced ThreadPicker with ThreadPicker modal.

Revision Contents
Changeset List

Diff 17427

View Options

web/calendar/day.react.js

Loading...
View Options

web/calendar/thread-picker.css

Loading...
View Options

web/calendar/thread-picker.react.js

Loading...