Page MenuHomePhabricator
Differential D5325

[native] Fix inline sidebar background color
ClosedPublic
Actions

Authored by bartek on Oct 10 2022, 3:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 18, 1:51 PM
Unknown Object (File)
Wed, Sep 18, 1:51 PM
Unknown Object (File)
Wed, Sep 18, 1:51 PM
Unknown Object (File)
Wed, Sep 18, 1:48 PM
Unknown Object (File)
Thu, Sep 12, 11:22 PM
Unknown Object (File)
Sat, Sep 7, 7:31 AM
Unknown Object (File)
Fri, Sep 6, 8:07 PM
Unknown Object (File)
Sep 5 2024, 8:02 AM
View All Files
Subscribers
• abosh
atul

Details

Reviewers
ashoat
tomek
atul
Commits
rCOMM469c8bf3efd8: [native] Fix inline sidebar background color
Summary

Fixes ENG-1954.
It turns out that sidebar wrapper/holder (with 100% width) had background color set to black. And because it has border radius set, the top-left corner looked OK (or the top-right in case when viewer is author of the message).

Fixed it by removing the background color and making the view opaque.

Test Plan

Tested in iOS simulator, used RN Element Inspector.

Temporarily set the background to green and disabled cornerRadius (1st screen) to show the element. The last screen shows final effect

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.06.png (2×1 px, 317 KB)

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.27.15.png (2×1 px, 301 KB)

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.33.png (2×1 px, 316 KB)

Diff Detail

Repository
rCOMM Comm
Branch
@barthap/inline-sidebar
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 10 2022, 3:42 AM
Herald added subscribers: • abosh, atul. · View Herald TranscriptOct 10 2022, 3:42 AM
bartek edited the test plan for this revision. (Show Details)Oct 10 2022, 3:45 AM
bartek attached a referenced file: F194577: Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.33.png. (Show Details)
bartek attached a referenced file: F194578: Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.27.15.png. (Show Details)
bartek attached a referenced file: F194579: Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.06.png. (Show Details)Oct 10 2022, 3:47 AM
Harbormaster completed remote builds in B12687: Diff 17437.Oct 10 2022, 3:52 AM
bartek requested review of this revision.Oct 10 2022, 3:52 AM
atul accepted this revision.Oct 10 2022, 7:27 AM

Thanks for linking the context on Linear, describing the issue and solution clearly, and providing screenshots showing the before/after

This revision is now accepted and ready to land.Oct 10 2022, 7:27 AM
Closed by commit rCOMM469c8bf3efd8: [native] Fix inline sidebar background color (authored by bartek). · Explain WhyOct 12 2022, 7:35 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM469c8bf3efd8: [native] Fix inline sidebar background color.

Revision Contents
Changeset List

PathSize
native/
chat/
1 line

Diff 17437

View Options

native/chat/inline-sidebar.react.js

Loading...