Page MenuHomePhabricator

[Services] Force c++17 usage with cxx builds
AbandonedPublic

Authored by jon on Oct 10 2022, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 8:57 AM
Unknown Object (File)
Thu, Sep 26, 8:57 AM
Unknown Object (File)
Thu, Sep 26, 8:53 AM
Unknown Object (File)
Fri, Sep 13, 1:47 AM
Unknown Object (File)
Fri, Sep 6, 10:39 PM
Unknown Object (File)
Aug 24 2024, 1:34 PM
Unknown Object (File)
Aug 24 2024, 1:33 PM
Unknown Object (File)
Aug 24 2024, 1:28 PM
Subscribers

Details

Summary

Before we can use the system C compiler, we have to force c++17 usage
for cxx builds. cxx's flag_if_supported does not get correctly passed
to the C compiler invocation. This is also needed because clang defaults to
C++03 unless otherwise specified.

Nix's clang compiler wasn't affected by this, as it would default to GCC12
behavior of using a more recent version.

Test Plan

Tunnelbroker nix gate passes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage