[iOS] Fix pod install and react-native with nix env
ClosedPublic
Actions

Authored by • jon on Oct 31 2022, 7:17 AM.

Details

Reviewers

atul
varun

Commits

rCOMM4c40865824a4: [iOS] Fix pod install and react-native with nix env

Summary

Force /usr/bin to be prefixed on PATH to ensure
that macOS tooling is found first for iOS builds. Otherwise build will
fail with GNU coreutils and Nix provided clang.

Test Plan

nix develop

# if you want to thoroughly clean everything
git clean -xfd

cd native/ios

# Remove and prune pod artifacts
pod deintegrate Comm.xcodeproj/
git checkout . # restore project

cd ../..

yarn cleaninstall # should also run pod install

# Assert that pod install succeeded
# gRPC-C++ is the pod likely to fail and gRPC-Core is a downstream dependency
ls native/ios/Pods/gRPC-Core

Depends on D5488

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Oct 31 2022, 7:17 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 31 2022, 7:17 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2022, 7:26 AM

Harbormaster failed remote builds in B13100: Diff 17986!

• jon added a child revision: D5479: [iOS] Support Nix iOS dev shell.Oct 31 2022, 7:42 AM

Harbormaster completed remote builds in B13100: Diff 17986.Oct 31 2022, 6:04 PM

• jon requested review of this revision.Oct 31 2022, 6:04 PM

• jon added 1 blocking reviewer(s): atul.Nov 1 2022, 10:53 AM

Did you test that things still work for the non-nix workflow?

Worked for me

This revision is now accepted and ready to land.Nov 2 2022, 12:35 PM

Did you test that things still work for the non-nix workflow?

No, but only /usr/local/bin is ordered in front of /usr/bin on my mac (by default), and it only contains items installed with homebrew. So it may have an effect, but the desire here is to get BSD versions of commands (e.g. sed), and the macOS native clang compiler.