[Nix] Move to rustup supplied tooling
ClosedPublic
Actions

Authored by • jon on Oct 31 2022, 7:26 AM.

Details

Reviewers

atul
varun

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMb3d927bea242: [Nix] Move to rustup supplied tooling

Summary

For compatibility with iOS target compilation, we need to avoid nix
provided rust tooling which only supports targeting the build platform.

Test Plan

nix develop

which rustc # points to rustup package in nix store

yarn cleaninstall # may not be necessary

cd native
yarn react-native run-ios --simulator='iPhone 14 Pro' --configuration=Release

Depends on D5479

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Oct 31 2022, 7:26 AM

Owners added a reviewer: Restricted Owners Package.Oct 31 2022, 7:26 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 31 2022, 7:26 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2022, 7:35 AM

Harbormaster failed remote builds in B13102: Diff 17988!

Harbormaster completed remote builds in B13102: Diff 17988.Oct 31 2022, 2:01 PM

• jon requested review of this revision.Oct 31 2022, 2:01 PM

varun accepted this revision.Nov 1 2022, 8:47 AM

varun added inline comments.

scripts/ensure_rustup_setup.sh
20–21 ↗	(On Diff #17988)	we probably want to add the android targets here as well, right?

This revision is now accepted and ready to land.Nov 1 2022, 8:47 AM

• jon added inline comments.Nov 1 2022, 10:52 AM

scripts/ensure_rustup_setup.sh
20–21 ↗	(On Diff #17988)	that's kind of outside of scope for what I'm trying to do here, which is just enable this rustup provisioning separately from running the build. I'll create a stub ticket to tackle this later https://linear.app/comm/issue/ENG-2155