Page MenuHomePhabricator
Differential D5354

[web] refactored modal.react.js in web to use lib Modal component
AbandonedPublic
Actions

Authored by ginsu on Oct 12 2022, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 5:22 AM
Unknown Object (File)
Fri, Sep 6, 10:41 PM
Unknown Object (File)
Fri, Sep 6, 10:41 PM
Unknown Object (File)
Thu, Sep 5, 5:47 AM
Unknown Object (File)
Sun, Sep 1, 2:00 PM
Unknown Object (File)
Tue, Aug 27, 10:53 PM
Unknown Object (File)
Sat, Aug 24, 9:38 AM
Unknown Object (File)
Sat, Aug 24, 9:38 AM
View All 72 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
rohan
• abosh
tomek
Summary

refactored modal.react.js in web to use lib Modal component. All the removed code in this diff now lives in lib/components/modal.react

Next Steps:

  1. Refactor modal-provider.js imports in web to use lib instead of web
  2. Refacor modal.react.js in landing
  3. Refactor modal-provider.js imports in landing to use lib instead of landing

Depends on D5353
Linear Task: ENG-2038

Test Plan

Please view the attached video to see that all modals act the same as before

Diff Detail

Repository
rCOMM Comm
Branch
eng-2038
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 12 2022, 1:09 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 12 2022, 1:09 PM
ginsu edited the summary of this revision. (Show Details)Oct 12 2022, 1:12 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, • abosh.
ginsu attached a referenced file: F197126: Screen Recording 2022-10-12 at 4.09.24 PM.mov. (Show Details)Oct 12 2022, 1:14 PM
ginsu edited the summary of this revision. (Show Details)Oct 12 2022, 1:16 PM
ginsu added a parent revision: D5353: [lib] introduced components/modal to lib.
Harbormaster completed remote builds in B12758: Diff 17526.Oct 12 2022, 1:20 PM
ginsu requested review of this revision.Oct 12 2022, 1:20 PM
ginsu added a child revision: D5355: [web] refactored modal-provider.js imports to use lib instead of web.Oct 12 2022, 1:50 PM
atul added a reviewer: tomek.Oct 13 2022, 8:38 AM
atul requested changes to this revision.Oct 13 2022, 12:01 PM

Back to your queue for now

This revision now requires changes to proceed.Oct 13 2022, 12:01 PM
ginsu requested review of this revision.Oct 13 2022, 12:21 PM
ginsu added inline comments.Oct 13 2022, 12:45 PM
web/modals/modal.css
1–13

This code now lives in lib/components/modal.css which was created in the previous diff

web/modals/modal.react.js
33–57

This code now lives in lib/components/modal.react.js which was created in the previous diff

87–93

This code now lives in lib/components/modal.react.js which was created in the previous diff

ginsu planned changes to this revision.Oct 13 2022, 1:36 PM
ginsu abandoned this revision.Oct 14 2022, 8:36 AM

abandoning diff due to better refactor strategy with other diffs

Revision Contents
Changeset List

PathSize
web/
modals/
14 lines
37 lines

Diff 17526

View Options

web/modals/modal.css

Loading...
View Options

web/modals/modal.react.js

Loading...