Paths

Table of Contentst

[web] refactored modal-provider.js imports to use lib instead of web
AbandonedPublic
Actions

Authored by ginsu on Oct 12 2022, 1:47 PM.

Details

Reviewers

atul
• abosh
rohan
tomek

Summary

refactored modal-provider.js imports to use lib instead of web. Also removed modal-provider.js in web since it is no longer being called

Next Steps:

Refacor modal.react.js in landing
Refactor modal-provider.js imports in landing to use lib instead of landing

Depends on D5354
Linear Task: ENG-2038

Test Plan

Please view the attached video to see that all the files are calling lib/components/modal-provider.react. Also everything compiles successfully and all modals act the same before which are all really strong indications that everything works

Diff Detail

Repository

rCOMM Comm

Branch

eng-2038 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 12 2022, 1:47 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 12 2022, 1:47 PM

ginsu edited the summary of this revision. (Show Details)Oct 12 2022, 1:50 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, • abosh, rohan.

ginsu added a parent revision: D5354: [web] refactored modal.react.js in web to use lib Modal component.

ginsu attached a referenced file: F197225: Screen Recording 2022-10-12 at 4.41.05 PM.mov. (Show Details)

Harbormaster completed remote builds in B12762: Diff 17530.Oct 12 2022, 1:57 PM

ginsu requested review of this revision.Oct 12 2022, 1:57 PM

atul added a reviewer: tomek.Oct 13 2022, 8:38 AM

Back to your queue for now

This revision now requires changes to proceed.Oct 13 2022, 12:01 PM

ginsu requested review of this revision.Oct 13 2022, 12:21 PM

ginsu planned changes to this revision.Oct 13 2022, 1:35 PM

abandoning diff due to better refactor strategy with other diffs

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.react.js

2 lines

app.react.js

5 lines

calendar/

day.react.js

2 lines

entry.react.js

2 lines

filter-panel.react.js

2 lines

chat/

chat-thread-list-see-more-sidebars.react.js

2 lines

thread-menu.react.js

2 lines

input/

input-state-container.react.js

2 lines

media/

multimedia-modal.react.js

3 lines

multimedia.react.js

3 lines

modals/

account/

log-in-first-modal.react.js

3 lines

log-in-modal.react.js

3 lines

alert.react.js

3 lines

concurrent-modification-modal.react.js

3 lines

history/

history-modal.react.js

2 lines

modal-provider.react.js

threads/

members/

members-modal.react.js

2 lines

settings/

thread-settings-delete-tab.react.js

2 lines

thread-settings-modal.react.js

2 lines

thread-settings-privacy-tab.react.js

2 lines

sidebars/

sidebar.react.js

2 lines

subchannels/

subchannel.react.js

2 lines

settings/

account-delete-modal.react.js

2 lines

account-settings.react.js

2 lines

danger-zone.react.js

3 lines

password-change-modal.js

2 lines

relationship/

block-list-modal.react.js

2 lines

friend-list-modal.react.js

2 lines

Diff 17530

View Options

web/account/log-in-form.react.js

View Options

web/app.react.js

View Options

web/calendar/day.react.js

View Options

web/calendar/entry.react.js

View Options

web/calendar/filter-panel.react.js

View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

View Options

web/chat/thread-menu.react.js

View Options

web/input/input-state-container.react.js

View Options

web/media/multimedia-modal.react.js

View Options

web/media/multimedia.react.js

View Options

web/modals/account/log-in-first-modal.react.js

View Options

web/modals/account/log-in-modal.react.js

View Options

web/modals/alert.react.js

View Options

web/modals/concurrent-modification-modal.react.js

View Options

web/modals/history/history-modal.react.js

View Options

web/modals/modal-provider.react.js

View Options

web/modals/threads/members/members-modal.react.js

View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

View Options

web/modals/threads/settings/thread-settings-modal.react.js

View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

View Options

web/modals/threads/sidebars/sidebar.react.js

View Options

web/modals/threads/subchannels/subchannel.react.js

View Options

web/settings/account-delete-modal.react.js

View Options

web/settings/account-settings.react.js

View Options

web/settings/danger-zone.react.js

View Options

web/settings/password-change-modal.js

View Options

web/settings/relationship/block-list-modal.react.js

View Options

web/settings/relationship/friend-list-modal.react.js

[web] refactored modal-provider.js imports to use lib instead of webAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17530

web/account/log-in-form.react.js

web/app.react.js

web/calendar/day.react.js

web/calendar/entry.react.js

web/calendar/filter-panel.react.js

web/chat/chat-thread-list-see-more-sidebars.react.js

web/chat/thread-menu.react.js

web/input/input-state-container.react.js

web/media/multimedia-modal.react.js

web/media/multimedia.react.js

web/modals/account/log-in-first-modal.react.js

web/modals/account/log-in-modal.react.js

web/modals/alert.react.js

web/modals/concurrent-modification-modal.react.js

web/modals/history/history-modal.react.js

web/modals/modal-provider.react.js

web/modals/threads/members/members-modal.react.js

web/modals/threads/settings/thread-settings-delete-tab.react.js

web/modals/threads/settings/thread-settings-modal.react.js

web/modals/threads/settings/thread-settings-privacy-tab.react.js

web/modals/threads/sidebars/sidebar.react.js

web/modals/threads/subchannels/subchannel.react.js

web/settings/account-delete-modal.react.js

web/settings/account-settings.react.js

web/settings/danger-zone.react.js

web/settings/password-change-modal.js

web/settings/relationship/block-list-modal.react.js

web/settings/relationship/friend-list-modal.react.js

[web] refactored modal-provider.js imports to use lib instead of web
AbandonedPublic
Actions

Revision Contents
Changeset List