Page MenuHomePhabricator
Differential D5356

[Nix] Use openssl 1.1 for nodejs
ClosedPublic
Actions

Authored by • jon on Oct 12 2022, 2:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 8:10 PM
Unknown Object (File)
Sat, Nov 9, 8:10 PM
Unknown Object (File)
Sat, Nov 9, 8:08 PM
Unknown Object (File)
Tue, Nov 5, 2:07 AM
Unknown Object (File)
Oct 14 2024, 10:44 PM
Unknown Object (File)
Oct 10 2024, 9:42 AM
Unknown Object (File)
Oct 5 2024, 5:38 PM
Unknown Object (File)
Oct 5 2024, 3:37 PM
View All Files
Subscribers
tomek

Details

Reviewers
• abosh
atul
varun
ashoat
rohan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM2c4cfd3b0d0c: [Nix] Use openssl 1.1 for nodejs
Summary

Force nodejs-16_x to use openssl 1.1 to preserve legacy openssl
behavior.

https://linear.app/comm/issue/ENG-2029/

Test Plan
nix develop
yarn cleaninstall # might be optional
cd landing
yarn prod

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/nodejs-openssl
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Oct 12 2022, 2:25 PM
Owners added a reviewer: Restricted Owners Package.Oct 12 2022, 2:25 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 12 2022, 2:25 PM
Harbormaster completed remote builds in B12764: Diff 17533.Oct 12 2022, 2:41 PM
• jon requested review of this revision.Oct 12 2022, 2:41 PM
ashoat accepted this revision.Oct 12 2022, 2:46 PM
atul added a comment.Oct 12 2022, 3:13 PM

Caching aside, is there a way to have it use "more of my computer" when it's building node?

Screen Shot 2022-10-12 at 6.12.16 PM.png (510×3 px, 863 KB)

• jon added a comment.Oct 12 2022, 3:19 PM

The ./scripts/install_nix.sh should provide you with defaults, currently it will give 4 cores per build. It's possible that the build is just single threaded for some reason.

• jon added a comment.Oct 12 2022, 3:24 PM

To anwser your question more directly, it's the max-jobs and cores values for nix.conf. https://nixos.org/manual/nix/stable/command-ref/conf-file.html

You should also be able to pass --jobs N --cores N to any nix command. Jobs are how many distinct packages it can build, and cores is how many cores per build it will use.

atul added a comment.Oct 12 2022, 4:15 PM

--cores N did the trick!

6eac8c.png (534×3 px, 391 KB)

atul accepted this revision.Oct 12 2022, 4:28 PM

ca86d2.png (1×2 px, 1 MB)

This revision is now accepted and ready to land.Oct 12 2022, 4:28 PM
rohan accepted this revision.Oct 13 2022, 3:46 AM

Thanks for the follow up on Linear!

Closed by commit rCOMM2c4cfd3b0d0c: [Nix] Use openssl 1.1 for nodejs (authored by • jon). · Explain WhyOct 13 2022, 10:06 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM2c4cfd3b0d0c: [Nix] Use openssl 1.1 for nodejs.
ashoat added a comment.Oct 13 2022, 1:19 PM
In D5356#158276, @jon wrote:

To anwser your question more directly, it's the max-jobs and cores values for nix.conf. https://nixos.org/manual/nix/stable/command-ref/conf-file.html

You should also be able to pass --jobs N --cores N to any nix command. Jobs are how many distinct packages it can build, and cores is how many cores per build it will use.

Is there a way we could default to the number of cores that the computer has?

• jon added a comment.Oct 18 2022, 10:15 AM

Is there a way we could default to the number of cores that the computer has?

This is done already as part of ./scripts/install_nix.sh

Revision Contents
Changeset List

PathSize
nix/
8 lines

Diff 17533

View Options

nix/overlay.nix

Loading...