Page MenuHomePhabricator
Differential D5363

[web] introduced ModalOverlay component
ClosedPublic
Actions

Authored by ginsu on Oct 13 2022, 2:25 PM.
Tags
None
Referenced Files
F3245877: D5363.diff
Thu, Nov 14, 8:32 PM
Unknown Object (File)
Fri, Nov 8, 3:28 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
View All Files
Subscribers
• abosh
ashoat
atul
• przemek
tomek

Details

Reviewers
atul
• abosh
rohan
• przemek
Commits
rCOMMb2a0ce970e0a: [web] introduced ModalOverlay component
Summary

introduced ModalOverlay component. The ModalOverlay component extracts the overlay logic from the Modal component into a separate component. Eventually we are going to want to migrate the ModalOverlay into lib

Linear Task: ENG-2038

Test Plan

Please watch the video to see that there are no visual or performance regressions with the new ModalOverlay component

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 13 2022, 2:25 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 13 2022, 2:25 PM
ginsu edited the summary of this revision. (Show Details)Oct 13 2022, 2:30 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, • abosh, rohan.
ginsu attached a referenced file: F198687: Screen Recording 2022-10-13 at 5.21.54 PM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)Oct 13 2022, 2:36 PM
Harbormaster completed remote builds in B12785: Diff 17559.Oct 13 2022, 2:36 PM
ginsu requested review of this revision.Oct 13 2022, 2:36 PM
ginsu updated this revision to Diff 17560.Oct 13 2022, 2:38 PM

made focus of this diff just moving code

Harbormaster completed remote builds in B12786: Diff 17560.Oct 13 2022, 2:48 PM
ginsu updated this revision to Diff 17561.Oct 13 2022, 2:49 PM

quick fix

Harbormaster completed remote builds in B12787: Diff 17561.Oct 13 2022, 3:00 PM
ginsu edited the summary of this revision. (Show Details)Oct 13 2022, 9:43 PM
ginsu added a child revision: D5364: [web] update ModalOverlay component.
ginsu updated this revision to Diff 17576.Oct 14 2022, 7:41 AM

rebase Przemek's code

ashoat added a reviewer: • przemek.Oct 14 2022, 7:47 AM
ashoat added a subscriber: • przemek.

Since @przemek just looked at the Modal code, figure he would be a good reviewer here

Harbormaster completed remote builds in B12800: Diff 17576.Oct 14 2022, 7:51 AM
• przemek accepted this revision.Oct 14 2022, 7:59 AM

Looks good to me :)

This revision is now accepted and ready to land.Oct 14 2022, 7:59 AM
ginsu added 1 blocking reviewer(s): atul.Oct 14 2022, 8:01 AM
This revision now requires review to proceed.Oct 14 2022, 8:01 AM
atul accepted this revision.Oct 14 2022, 11:25 AM

Thanks!!

Guessing it was a bit tedious to redo work you'd already done, but this is way easier to review

This revision is now accepted and ready to land.Oct 14 2022, 11:25 AM
Closed by commit rCOMMb2a0ce970e0a: [web] introduced ModalOverlay component (authored by ginsu). · Explain WhyOct 14 2022, 12:24 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb2a0ce970e0a: [web] introduced ModalOverlay component.

Revision Contents
Changeset List

PathSize
web/
modals/
13 lines
54 lines
14 lines
36 lines

Diff 17561

View Options

web/modals/modal-overlay.css

Loading...
View Options

web/modals/modal-overlay.react.js

Loading...
View Options

web/modals/modal.css

Loading...
View Options

web/modals/modal.react.js

Loading...