Page MenuHomePhabricator
Differential D5364

[web] update ModalOverlay component
ClosedPublic
Actions

Authored by ginsu on Oct 13 2022, 3:00 PM.
Tags
None
Referenced Files
F3403003: D5364.diff
Mon, Dec 2, 11:46 PM
Unknown Object (File)
Thu, Nov 28, 11:32 PM
Unknown Object (File)
Mon, Nov 25, 10:37 PM
Unknown Object (File)
Sun, Nov 24, 12:40 PM
Unknown Object (File)
Sun, Nov 24, 12:39 PM
Unknown Object (File)
Fri, Nov 8, 3:28 AM
Unknown Object (File)
Oct 28 2024, 5:09 AM
Unknown Object (File)
Oct 28 2024, 5:09 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
rohan
• abosh
• przemek
Commits
rCOMM11f8c6c7eeb9: [web] update ModalOverlay component
Summary

updated ModalOverlay component by changing background-color of overlay to hex value because hex values are more frequently used in the codebase, and changed useEffect to useLayoutEffect. Reasoning for that here

Depends on D5363
Linear Task: ENG-2038

Test Plan

Please watch the video to see that there are no visual or performance regressions with these updates to the ModalOverlay component and everything works as it did previously

Diff Detail

Repository
rCOMM Comm
Branch
eng-2038v2 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 13 2022, 3:00 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 13 2022, 3:00 PM
ginsu edited the summary of this revision. (Show Details)Oct 13 2022, 3:02 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, • abosh.
ginsu attached a referenced file: F198780: Screen Recording 2022-10-13 at 5.55.18 PM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B12789: Diff 17563.Oct 13 2022, 3:11 PM
ginsu requested review of this revision.Oct 13 2022, 3:11 PM
ginsu edited the summary of this revision. (Show Details)Oct 13 2022, 9:44 PM
ginsu added a parent revision: D5363: [web] introduced ModalOverlay component.
ginsu updated this revision to Diff 17577.Oct 14 2022, 7:50 AM

rebase

ashoat added a reviewer: • przemek.Oct 14 2022, 7:54 AM
Harbormaster completed remote builds in B12801: Diff 17577.Oct 14 2022, 7:58 AM
ginsu added 1 blocking reviewer(s): atul.Oct 14 2022, 8:02 AM
• przemek accepted this revision.Oct 14 2022, 8:03 AM

Looks good, thanks for linking discussion on Linear, it made the changes clear

ginsu added a child revision: D5370: [lib] moved ModalOverlay component from web to lib.Oct 14 2022, 8:21 AM
atul accepted this revision.Oct 14 2022, 11:57 AM
This revision is now accepted and ready to land.Oct 14 2022, 11:57 AM
Closed by commit rCOMM11f8c6c7eeb9: [web] update ModalOverlay component (authored by ginsu). · Explain WhyOct 14 2022, 12:24 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM11f8c6c7eeb9: [web] update ModalOverlay component.

Revision Contents
Changeset List

PathSize
web/
modals/
2 lines
12 lines

Diff 17563

View Options

web/modals/modal-overlay.css

Loading...
View Options

web/modals/modal-overlay.react.js

Loading...