Paths

Table of Contentst

[lib] moved ModalOverlay component from web to lib
ClosedPublic
Actions

Authored by ginsu on Oct 14 2022, 3:01 PM.

Details

Reviewers

atul
rohan
• abosh
• przemek

Commits

rCOMMa008b28c7137: [lib] moved ModalOverlay component from web to lib

Summary

moved modal-overlay.react and modal-overlay.css from web to lib.

Depends on D5364
Linear Task: ENG-2038

Test Plan

Please watch the video to see that there are no visual or performance regressions with the migration of ModalOverlay from web to lib

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 14 2022, 3:01 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 14 2022, 3:01 PM

ginsu edited the test plan for this revision. (Show Details)Oct 14 2022, 3:06 PM

ginsu added reviewers: atul, rohan, • abosh, • przemek.

ginsu attached a referenced file: F199261: Screen Recording 2022-10-14 at 10.58.42 AM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B12802: Diff 17578.Oct 14 2022, 3:11 PM

ginsu requested review of this revision.Oct 14 2022, 3:11 PM

ginsu edited the summary of this revision. (Show Details)Oct 14 2022, 3:21 PM

ginsu added a parent revision: D5364: [web] update ModalOverlay component.

ginsu added a child revision: D5372: [lib] moved modal-provider.react from web to lib.Oct 14 2022, 3:32 PM

Super clean!

This revision is now accepted and ready to land.Oct 14 2022, 6:57 PM

Closed by commit rCOMMa008b28c7137: [lib] moved ModalOverlay component from web to lib. · Explain WhyOct 14 2022, 7:24 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMa008b28c7137: [lib] moved ModalOverlay component from web to lib.

Revision Contents
Changeset List

Path

Size

	lib/	components/
	web/	modals/

modal-overlay.css

modal-overlay.react.js

web/

modals/

modal-overlay.css

modal-overlay.react.js

modal.react.js

3 lines

Diff 17590

View Options

lib/components/modal-overlay.css

View Options

lib/components/modal-overlay.react.js

View Options

web/modals/modal-overlay.css

View Options

web/modals/modal-overlay.react.js

View Options

[lib] moved ModalOverlay component from web to libClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17590

lib/components/modal-overlay.css

lib/components/modal-overlay.react.js

web/modals/modal-overlay.css

web/modals/modal-overlay.react.js

web/modals/modal.react.js

[lib] moved ModalOverlay component from web to lib
ClosedPublic
Actions

Revision Contents
Changeset List