[keyserver] Update node version to 16.18.0
ClosedPublic
Actions

Authored by rohan on Oct 24 2022, 9:18 AM.

Details

Reviewers

ashoat
atul
• abosh

Commits

rCOMMdf1fe62e4899: [keyserver] Update node version to 16.18.0

Summary

This is the final step for ENG-929
(https://linear.app/comm/issue/ENG-929/fix-issues-with-node-1614-import-syntax-assertions).
I changed the node version in keyserver/.nvmrc and the tag in the first
line of keyserver/Dockerfile.

Test Plan

After changing the version, I ran yarn cleaninstall, and
tested yarn dev and yarn prod in both web and landing, yarn dev
in native, and yarn prod-build followed by yarn prod in
keyserver. All of the above run successfully.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Oct 24 2022, 9:18 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 24 2022, 9:18 AM

Harbormaster completed remote builds in B13002: Diff 17861.Oct 24 2022, 9:31 AM

rohan requested review of this revision.Oct 24 2022, 9:31 AM

rohan edited the test plan for this revision. (Show Details)Oct 24 2022, 9:37 AM

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

This revision is now accepted and ready to land.Oct 24 2022, 9:39 AM

In D5467#161598, @ashoat wrote:

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

Is there anything I should wait for (any other tasks/testing/etc) before landing or is it good to officially land?

In D5467#161705, @rohan wrote:

In D5467#161598, @ashoat wrote:

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

Is there anything I should wait for (any other tasks/testing/etc) before landing or is it good to officially land?