Page MenuHomePhabricator

[keyserver] Update node version to 16.18.0
ClosedPublic

Authored by rohan on Oct 24 2022, 9:18 AM.
Tags
None
Referenced Files
F3529947: D5467.diff
Tue, Dec 24, 10:26 PM
Unknown Object (File)
Fri, Dec 6, 6:02 PM
Unknown Object (File)
Tue, Nov 26, 5:14 PM
Unknown Object (File)
Tue, Nov 26, 5:14 PM
Unknown Object (File)
Tue, Nov 26, 5:14 PM
Unknown Object (File)
Mon, Nov 25, 7:41 PM
Unknown Object (File)
Mon, Nov 25, 3:47 AM
Unknown Object (File)
Nov 2 2024, 9:54 PM
Subscribers

Details

Summary

This is the final step for ENG-929
(https://linear.app/comm/issue/ENG-929/fix-issues-with-node-1614-import-syntax-assertions).
I changed the node version in keyserver/.nvmrc and the tag in the first
line of keyserver/Dockerfile.

Test Plan

After changing the version, I ran yarn cleaninstall, and
tested yarn dev and yarn prod in both web and landing, yarn dev
in native, and yarn prod-build followed by yarn prod in
keyserver. All of the above run successfully.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Oct 24 2022, 9:31 AM

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

This revision is now accepted and ready to land.Oct 24 2022, 9:39 AM

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

Is there anything I should wait for (any other tasks/testing/etc) before landing or is it good to officially land?

In D5467#161705, @rohan wrote:

Great test plan, and CI looks like it's passing!! Really exciting to get this resolved finally :)

Is there anything I should wait for (any other tasks/testing/etc) before landing or is it good to officially land?

I think it's good to land. I think we've been fairly thorough in verifying that things continue to work as expected.

If there is some issue that comes up we can revert the change, but I'd be surprised.

This revision was automatically updated to reflect the committed changes.