Page MenuHomePhabricator
Differential D5483

added tests to check spoiler regex extracted values
ClosedPublic
Actions

Authored by • manan on Oct 25 2022, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:29 AM
Unknown Object (File)
Sat, Oct 26, 5:23 PM
Unknown Object (File)
Oct 15 2024, 5:22 PM
Unknown Object (File)
Oct 10 2024, 6:56 AM
Unknown Object (File)
Oct 10 2024, 6:56 AM
Unknown Object (File)
Oct 10 2024, 6:56 AM
Unknown Object (File)
Oct 10 2024, 6:55 AM
Unknown Object (File)
Oct 10 2024, 6:54 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
ginsu
atul
rohan
Commits
rCOMMc23876e01ba4: added tests to check spoiler regex extracted values
Summary

added a few tests to make sure the spoiler regex is actually
extracting the correct spoiler text.

Test Plan

tested manually by hand

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• manan created this revision.Oct 25 2022, 7:09 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 25 2022, 7:09 PM
Harbormaster completed remote builds in B13045: Diff 17915.Oct 25 2022, 7:22 PM
• manan requested review of this revision.Oct 25 2022, 7:22 PM
ginsu requested changes to this revision.Oct 26 2022, 7:37 AM
ginsu added inline comments.
lib/shared/markdown.test.js
56 ↗(On Diff #17915)

we should be using const. Here is more context

This revision now requires changes to proceed.Oct 26 2022, 7:37 AM
tomek added inline comments.Oct 26 2022, 9:41 AM
lib/shared/markdown.test.js
56 ↗(On Diff #17915)

It's surprising that eslint haven't caught that. Maybe we don't have no-var rule enabled. Could you create a task to check and add the rule?

• manan updated this revision to Diff 17956.Oct 27 2022, 8:42 AM
  1. Updating D5483: added tests to check spoiler regex extracted values #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

fixed var variable declarations - changed to const.

Harbormaster completed remote builds in B13079: Diff 17956.Oct 27 2022, 8:56 AM
atul added 1 blocking reviewer(s): rohan.Oct 27 2022, 9:36 AM
ginsu added a comment.Oct 27 2022, 10:17 AM

https://linear.app/comm/issue/ENG-2125/eslint-enable-no-var-rule

ginsu accepted this revision.Oct 27 2022, 10:20 AM

lgtm

rohan accepted this revision.Oct 28 2022, 6:57 AM

Looks good, thanks for taking the suggestion from the other diff!

This revision is now accepted and ready to land.Oct 28 2022, 6:57 AM
Closed by commit rCOMMc23876e01ba4: added tests to check spoiler regex extracted values (authored by mananmanchanda <mananmanchanda@mananmanchandas-MacBook-Air.local>). · Explain WhyOct 30 2022, 10:35 PM
This revision was automatically updated to reflect the committed changes.
mananmanchanda <mananmanchanda@mananmanchandas-MacBook-Air.local> added a commit: rCOMMc23876e01ba4: added tests to check spoiler regex extracted values.
• manan added a comment.Oct 30 2022, 10:36 PM

Landed changes.

Revision Contents
Changeset List

PathSize
lib/
shared/
30 lines

Diff 17956

View Options

lib/shared/markdown.test.js

Loading...