Page MenuHomePhabricator
Differential D5484

[keyserver] Avoid concurrently calling source-nvm.sh in yarn dev
ClosedPublic
Actions

Authored by ashoat on Oct 26 2022, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:43 AM
Unknown Object (File)
Fri, Nov 8, 7:00 AM
Unknown Object (File)
Tue, Nov 5, 2:07 AM
Unknown Object (File)
Oct 5 2024, 5:41 PM
Unknown Object (File)
Oct 5 2024, 5:41 PM
Unknown Object (File)
Oct 5 2024, 5:41 PM
Unknown Object (File)
Oct 5 2024, 5:38 PM
Unknown Object (File)
Oct 4 2024, 9:35 PM
View All Files
Subscribers
• abosh
tomek

Details

Reviewers
atul
inka
Commits
rCOMMc3cffb144412: [keyserver] Avoid concurrently calling source-nvm.sh in yarn dev
Summary

yarn dev currently calls source-nvm.sh twice at the same time. If the version of Node is not installed already, both calls will trigger an install.

The result is that one of the calls "clobbers" the other one's download, and the other call decides that the download failed and it needs to compile Node from source (which takes a long time).

This diff makes sure we call source-nvm.sh at the start (not concurrently), and wait for it to finish before we call the other commands.

Test Plan
  1. nvm uninstall 16.18 and run yarn dev again
  2. Replaced the nodemon call with a node --version call, which confirmed I needed to keep the source-nvm.sh in front of that part of the command

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 26 2022, 7:24 AM
Herald added subscribers: • abosh, tomek. · View Herald TranscriptOct 26 2022, 7:24 AM
ashoat added inline comments.Oct 26 2022, 7:26 AM
keyserver/package.json
16 ↗(On Diff #17917)

For @atul's context: I had to keep the source-nvm.sh in front of nodemon, otherwise it didn't run the right version

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 26 2022, 7:34 AM
Harbormaster failed remote builds in B13047: Diff 17917!
Harbormaster completed remote builds in B13047: Diff 17917.Oct 26 2022, 7:47 AM
ashoat requested review of this revision.Oct 26 2022, 7:47 AM
atul accepted this revision.Oct 26 2022, 7:48 AM
atul added inline comments.
keyserver/package.json
16 ↗(On Diff #17917)

Thanks for explaining

This revision is now accepted and ready to land.Oct 26 2022, 7:48 AM
Closed by commit rCOMMc3cffb144412: [keyserver] Avoid concurrently calling source-nvm.sh in yarn dev (authored by ashoat). · Explain WhyOct 26 2022, 9:53 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMc3cffb144412: [keyserver] Avoid concurrently calling source-nvm.sh in yarn dev.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines

Diff 17922

View Options

keyserver/package.json

Loading...