Page MenuHomePhabricator
Differential D5486

[services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file
ClosedPublic
Actions

Authored by • max on Oct 26 2022, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 10:24 PM
Unknown Object (File)
Fri, Oct 25, 10:24 PM
Unknown Object (File)
Fri, Oct 25, 10:24 PM
Unknown Object (File)
Fri, Oct 25, 10:23 PM
Unknown Object (File)
Fri, Oct 25, 10:20 PM
Unknown Object (File)
Oct 6 2024, 4:41 AM
Unknown Object (File)
Oct 6 2024, 4:05 AM
Unknown Object (File)
Oct 6 2024, 4:02 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
varun
marcin
tomek
Commits
rCOMM89f260e671ae: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file
Summary

This diff moves the FFI functions from CXX from main.rs to the cxx_bridge.rs file.
The reason for moving the FFI away from the main.rs to its own scope is that the ffi::* functions should be called from the gRPC server handlers (for example in D5487).

Linear task: ENG-2094

Test Plan

The service was successfully built with the CI process or can be built manually using the cargo build command in services/tunnelbroker directory.

Diff Detail

Repository
rCOMM Comm
Branch
move-ffi-to-cxx-bridge
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Oct 26 2022, 9:36 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptOct 26 2022, 9:36 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• max added a parent revision: D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers.Oct 26 2022, 9:36 AM
• max added a child revision: D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Harbormaster completed remote builds in B13050: Diff 17920.Oct 26 2022, 9:47 AM
• max published this revision for review.Oct 26 2022, 10:02 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, marcin.
• jon accepted this revision.Oct 26 2022, 1:45 PM

seems logical to me

This revision is now accepted and ready to land.Oct 26 2022, 1:45 PM
• max added a reviewer: tomek.Oct 27 2022, 2:26 AM
This revision now requires review to proceed.Oct 27 2022, 2:26 AM
tomek accepted this revision.Oct 27 2022, 5:23 AM

Ideally, we should update an existing diff instead of introducing a new one, but for now let's keep it.

This revision is now accepted and ready to land.Oct 27 2022, 5:23 AM
• max updated this revision to Diff 18156.Nov 7 2022, 10:10 AM

Rebasing on the master changes.

• max removed a parent revision: D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers.Nov 7 2022, 10:18 AM
• max removed a child revision: D5487: [services] Tunnelbroker - Adding of gRPC `SessionSignature` implementation.
Harbormaster completed remote builds in B13230: Diff 18156.Nov 7 2022, 10:25 AM
Closed by commit rCOMM89f260e671ae: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file (authored by • max). · Explain WhyNov 7 2022, 10:31 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM89f260e671ae: [services] Tunnelbroker - Move ffi from `main.rs` to the `cxx_bridge.rs` file.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
2 lines
src/
7 lines
11 lines

Diff 17920

View Options

services/tunnelbroker/build.rs

Loading...
View Options

services/tunnelbroker/src/cxx_bridge.rs

Loading...
View Options

services/tunnelbroker/src/main.rs

Loading...