Details

Reviewers

tomek
marcin
varun
ashoat

Commits

rCOMM131f99f35a9c: [native] Introduce `useStaffCanSee()`

Summary

Context: https://linear.app/comm/issue/ENG-2134/have-a-flag-that-indicates-whether-the-build-is-a-staff-release

Utility that tells us whether we're running a debug build (__DEV__) and/or are "staff" (isStaff(state.currentUserInfo.id)) and/or are on a staff release (isStaffRelease).

In subsequent diff will use this function where isStaff || __DEV__ checks were used in the past.

Test Plan

Logged values and they were as expected:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D5498 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 28 2022, 12:16 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptOct 28 2022, 12:16 PM

atul added inline comments.Oct 28 2022, 12:25 PM

native/utils/staff-utils.js
7 ↗	(On Diff #17967)	Will set this value to `true` when I make staff releases

Harbormaster completed remote builds in B13089: Diff 17967.Oct 28 2022, 12:30 PM

atul requested review of this revision.Oct 28 2022, 12:30 PM

atul added a child revision: D5499: [native] Introduce `StaffContext`.Oct 28 2022, 12:46 PM

atul edited the test plan for this revision. (Show Details)Oct 28 2022, 12:47 PM

Might be good to update places that check __DEV__ || isStaff in this diff

This revision is now accepted and ready to land.Oct 28 2022, 1:33 PM

In D5498#162741, @ashoat wrote:

Might be good to update places that check __DEV__ || isStaff in this diff

Will update this diff

Three places I found that need to be changed (by searching __DEV__ and isStaff in native):

input-state-container
sqlite-context-provider
profile-screen

use useStaffCanSee throughout native

think i got them all, i'll do another scan through

This revision is now accepted and ready to land.Oct 31 2022, 1:04 PM

atul requested review of this revision.Oct 31 2022, 1:19 PM

atul added inline comments.

native/profile/profile-screen.react.js
56–70 ↗	(On Diff #17998)	Sorry, snuck in repositioning of `props` here so they're above the component they correspond to

Ensure truthiness of state.currentUserInfo && state.currentUserInfo.id before isStaff(...) check

Harbormaster completed remote builds in B13110: Diff 17998.Oct 31 2022, 1:33 PM

Harbormaster completed remote builds in B13114: Diff 18003.Oct 31 2022, 1:46 PM

ashoat accepted this revision.Nov 1 2022, 5:18 AM

This revision is now accepted and ready to land.Nov 1 2022, 5:18 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 1 2022, 10:33 AM

Closed by commit rCOMM131f99f35a9c: [native] Introduce `useStaffCanSee()` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM131f99f35a9c: [native] Introduce `useStaffCanSee()`.

Harbormaster completed remote builds in B13121: Diff 18011.Nov 1 2022, 10:46 AM

tomek mentioned this in D6967: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 2:07 AM

tomek mentioned this in rCOMM3dc46d29f50b: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 7:12 AM

[native] Introduce `useStaffCanSee()`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 18011

native/data/sqlite-context-provider.js

native/input/input-state-container.react.js

native/profile/profile-screen.react.js

native/utils/staff-utils.js

[native] Introduce `useStaffCanSee()`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18011

native/data/sqlite-context-provider.js

native/input/input-state-container.react.js

native/profile/profile-screen.react.js

native/utils/staff-utils.js

[native] Introduce `useStaffCanSee()`
ClosedPublic
Actions

Revision Contents
Changeset List