Page MenuHomePhabricator
Differential D5502

Revert "[native] Add JSI functions for creating/setting and fetching device ID"
AbandonedPublicDraft
Actions

Authored by inka on Oct 31 2022, 12:50 AM.
Tags
None
Referenced Files
F3155541: D5502.diff
Tue, Nov 5, 10:59 AM
Unknown Object (File)
Fri, Oct 11, 10:40 AM
Unknown Object (File)
Thu, Oct 10, 2:25 PM
Unknown Object (File)
Thu, Oct 10, 2:24 PM
Unknown Object (File)
Thu, Oct 10, 2:20 PM
Unknown Object (File)
Sep 5 2024, 9:14 PM
Unknown Object (File)
Sep 5 2024, 9:14 PM
Unknown Object (File)
Sep 5 2024, 9:14 PM
View All 82 Files
Subscribers
• abosh

Details

Reviewers
ashoat
tomek
varun
atul
• jon
Summary

This reverts commit ee24602c5622165d427b0c5fd4276c6531393250.

Test Plan

The test is pushing to phabricator and seeing if CI fails

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 31 2022, 12:50 AM
Herald added a reviewer: • jon. · View Herald TranscriptOct 31 2022, 12:50 AM
Herald added a subscriber: • abosh. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2022, 12:58 AM
Harbormaster failed remote builds in B13094: Diff 17980!
inka abandoned this revision.Nov 2 2022, 1:20 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
3 lines
45 lines
_generated/
schema/
2 lines

Diff 17980

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.h

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.cpp

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...