added no-var rule to root level eslint
ClosedPublic
Actions

Authored by • manan on Nov 1 2022, 11:19 AM.

Details

Reviewers

atul
rohan
ginsu

Commits

rCOMMfc0d37a56c5b: added no-var rule to root level eslint

Summary

added no-var rule to root level eslint

Test Plan

Went to a few files before committing eslint change, and I was
able to see that var cannot be used.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• manan created this revision.Nov 1 2022, 11:19 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 1 2022, 11:19 AM

Harbormaster completed remote builds in B13122: Diff 18013.Nov 1 2022, 11:33 AM

• manan requested review of this revision.Nov 1 2022, 11:33 AM

ginsu accepted this revision.Nov 1 2022, 1:36 PM

This revision is now accepted and ready to land.Nov 1 2022, 1:36 PM

ginsu added 1 blocking reviewer(s): atul.Nov 1 2022, 1:36 PM

This revision now requires review to proceed.Nov 1 2022, 1:36 PM

rohan accepted this revision.Nov 1 2022, 2:15 PM

tomek added inline comments.Nov 2 2022, 3:23 AM

.eslintrc.json
38	Most of the rules use strings instead of numbers - I think we should prefer that approach as it is more readable

rule changed from number to string for readability

• manan mentioned this in D5520: changed rule to use string instead of number.Nov 2 2022, 11:04 AM

• manan added inline comments.Nov 2 2022, 11:06 AM

.eslintrc.json
38	Most of the rules use strings instead of numbers - I think we should prefer that approach as it is more readable Fixed!

Harbormaster completed remote builds in B13136: Diff 18030.Nov 2 2022, 11:17 AM

atul accepted this revision.Nov 2 2022, 12:23 PM

This revision is now accepted and ready to land.Nov 2 2022, 12:23 PM

Landed

mananmanchanda <mananmanchanda@mananmanchandas-MacBook-Air.local> added a commit: rCOMMfc0d37a56c5b: added no-var rule to root level eslint.Nov 2 2022, 3:54 PM

Revision Contents
Changeset List

Path

Size

.eslintrc.json

1 line

Diff 18013

View Options

added no-var rule to root level eslintClosedPublicActions