[lib] Utils for typeahead mentions
ClosedPublic
Actions

Authored by • przemek on Nov 4 2022, 4:58 AM.

Details

Reviewers

tomek
kamil
atul

Commits

rCOMM38225b76efee: [lib] Utils for typeahead mentions

Summary

Preparation for typeahead user suggestions feature.
Utilities: - function getTypeaheadUserSuggestions() used to filter out users from current thread based on already typed prefix.

Also added stringForUserExplicit(), because when we use @-ing and we @ ourselves, we want to use our name, not "you",
e.g. I'd type: @przemek, instead od @you, which feels weird.

Test Plan

This is not called anywhere yet.
I runned web app and it still works the same.
Checked visibility of functions.

Diff Detail

Repository

rCOMM Comm

Branch

feat/mention

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Nov 4 2022, 4:58 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 4 2022, 4:58 AM

• przemek edited the summary of this revision. (Show Details)Nov 4 2022, 5:00 AM

• przemek edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13167: Diff 18071.Nov 4 2022, 5:12 AM

• przemek requested review of this revision.Nov 4 2022, 5:12 AM

tomek requested changes to this revision.Nov 4 2022, 8:45 AM

tomek added inline comments.

lib/shared/mention-utils.js
13–14	It would be safer to check if `username` is defined instead of depending on the external function. Also it isn't clear if that function is needed at all, because we're basically interested in just the users with `username`.
16	It is inefficient to iterate every user after every letter change. Please take a look at `SearchIndex` - can it be used here?
lib/shared/user-utils.js
18–36	It might be a good idea to make one function dependent on the other