Details
Connect to the bidirectional gRPC MessagesStream stream with the valid sessionID in metadata and send the message to the server with the NewNotifyToken field value as a random string.
The expected behavior is that the value will be written into the sessions table of the dynamoDB database into the NotifyToken field.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/tunnelbroker/src/server/mod.rs | ||
|---|---|---|
| 173–174 ↗ | (On Diff #18080) | Tonic forces us to provide all the implementations for the oneof gRPC messages otherwise the build will fail. |
| services/tunnelbroker/src/server/mod.rs | ||
|---|---|---|
| 179 ↗ | (On Diff #18080) |
This should be the actual error because in this case, something is wrong with the database, but I agree that we should use tracing instead. |
| services/tunnelbroker/src/server/mod.rs | ||
|---|---|---|
| 179 ↗ | (On Diff #18080) | Shouldn't we somehow inform the client that an attempt to set a token failed? |
Adding of the internal error to the client in case of the error on updating the token in a database.
Rebasing and fix merge conflicts.
| services/tunnelbroker/src/server/mod.rs | ||
|---|---|---|
| 179 ↗ | (On Diff #18080) |
Makes sense to return an internal error to the client. I've added returning of the gRPC Internal error in this case. Thanks, @tomek! |