Details

Reviewers

tomek
atul
kamil
ashoat

Commits

rCOMM320c11ffa73f: Introduce messages field in MessageStore during rehydration

Summary

This revision introduces empty messages field in MessageStore. This is essential change. The context why is here: https://linear.app/comm/issue/ENG-2133/sqlitecontextprovider-should-not-run-when-user-is-logged-out

Test Plan

Use messageInfoSelector in a place before SQLiteContextProvider dispatches action setMessageStoreMessages. Before this diff it will fail. I will not after.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Nov 7 2022, 9:23 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 7 2022, 9:24 AM

Rebase to master to fix android build failure

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 9:28 AM

Harbormaster failed remote builds in B13225: Diff 18149!

Harbormaster completed remote builds in B13223: Diff 18147.Nov 7 2022, 9:41 AM

Rebase master to retrigger CI

marcin added a parent revision: D5543: Run SQLite queries in parallel in SQLiteContextProvider.Nov 8 2022, 7:10 AM

marcin added a child revision: D5555: Ensure SQLiteContextProvider doesn't query SQLite and modify redux if user is logged out..

Harbormaster completed remote builds in B13261: Diff 18196.Nov 8 2022, 7:21 AM

marcin requested review of this revision.Nov 8 2022, 7:21 AM

Short-circuiting review here... I reviewed this approach extensively with @marcin during our 1:1 yesterday and in the comments of ENG-2133, so I think it's good to land.

This revision is now accepted and ready to land.Nov 8 2022, 7:52 AM

Rebase before landing

Harbormaster completed remote builds in B13301: Diff 18246.Nov 9 2022, 1:13 AM

Closed by commit rCOMM320c11ffa73f: Introduce messages field in MessageStore during rehydration (authored by marcin). · Explain WhyNov 9 2022, 1:30 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM320c11ffa73f: Introduce messages field in MessageStore during rehydration.

atul mentioned this in D5762: [native] Modify `messageStoreMessagesBlockListTransform` to ensure messageStore migration completes successfully.Nov 29 2022, 7:23 PM

atul mentioned this in rCOMM4a5089d43513: [native] Modify `messageStoreMessagesBlockListTransform` to ensure messageStore….Nov 30 2022, 8:56 AM