Paths

Table of Contentst

Differential D5554

[CI] Stop passing provisioning profile to iOS workflows
ClosedPublic
Actions

Authored by atul on Nov 7 2022, 8:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 25, 11:57 PM

	Unknown Object (File)
	Wed, Dec 25, 11:57 PM

	Unknown Object (File)
	Wed, Dec 25, 11:57 PM

	Unknown Object (File)
	Wed, Dec 25, 11:57 PM

	Unknown Object (File)
	Wed, Dec 25, 11:46 PM

	Unknown Object (File)
	Nov 22 2024, 7:59 AM

	Unknown Object (File)
	Nov 22 2024, 7:59 AM

	Unknown Object (File)
	Nov 22 2024, 7:59 AM

View All 81 Files

Subscribers

Details

Reviewers

tomek
marcin
varun
ginsu
rohan
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM69d4ad1f8e5b: [CI] Stop passing provisioning profile to iOS workflows

Summary

We don't need to be passing a provisioning profile for iOS workflows since they'll be pulled from AppStoreConnect anyways thanks to the -allowProvisioningUpdates flag passed to xcodebuild.

The provisioning profile we were previously passing was being ignored and replaced by both the app.comm and app.comm.NotificationService provisioning profiles.

Figured removing this would make things less misleading to any future readers.

Test Plan

Land and see what happens.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 7 2022, 8:12 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 7 2022, 8:12 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 8:18 PM

Harbormaster failed remote builds in B13245: Diff 18173!

atul requested review of this revision.Nov 7 2022, 8:21 PM

ginsu accepted this revision.Nov 7 2022, 8:26 PM

This revision is now accepted and ready to land.Nov 7 2022, 8:26 PM

Harbormaster completed remote builds in B13245: Diff 18173.Nov 7 2022, 8:31 PM

atul added a reviewer: Restricted Owners Package.Nov 8 2022, 4:56 AM

This revision now requires review to proceed.Nov 8 2022, 4:56 AM

ashoat accepted this revision.Nov 8 2022, 5:08 AM

This revision is now accepted and ready to land.Nov 8 2022, 5:08 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 8 2022, 6:48 AM

Closed by commit rCOMM69d4ad1f8e5b: [CI] Stop passing provisioning profile to iOS workflows (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM69d4ad1f8e5b: [CI] Stop passing provisioning profile to iOS workflows.

Harbormaster completed remote builds in B13258: Diff 18192.Nov 8 2022, 7:01 AM

Revision Contents
Changeset List

Path

Size

.github/

workflows/

11 lines

ios_release.yml

11 lines

11 lines

Diff 18193

.github/workflows/ios_ci.yml

Loading...

.github/workflows/ios_release.yml

Loading...

.github/workflows/ios_xctest.yml

Loading...