Page MenuHomePhabricator

[web] Extract thread-related selectors out of web/selectors/nav-selectors
ClosedPublic

Authored by rohan on Nov 10 2022, 6:30 AM.
Tags
None
Referenced Files
F3375954: D5593.id18312.diff
Tue, Nov 26, 9:32 PM
Unknown Object (File)
Sun, Nov 24, 6:32 AM
Unknown Object (File)
Sun, Nov 24, 6:32 AM
Unknown Object (File)
Sun, Nov 24, 6:32 AM
Unknown Object (File)
Thu, Nov 21, 3:19 PM
Unknown Object (File)
Oct 27 2024, 2:16 PM
Unknown Object (File)
Oct 1 2024, 5:56 PM
Unknown Object (File)
Sep 27 2024, 8:22 PM

Details

Summary

There is currently a "require" chain between keyserver and web/markdown, where it makes it impossible to use css files within the directory since keyserver is unable to handle it. Context:
https://linear.app/comm/issue/ENG-2206/extract-useonclickpendingsidebar-from-webselectorsnav-selectors#comment-31e14467. This means that in order to get around this, we need to break this "require" chain to
enable the use of css files in MarkdownSpoiler. This diff handles that - we separate the thread-like selectors out of web/selectors/nav-selectors into a new file, web/selectors/thread-selectors, and
fix the import statements around the codebase. This allows this chain to be broken and, after testing, MarkdownSpoiler importing a css file throws no error.

Depends on D5553

Test Plan

Restart both keyserver and web with yarn dev, and there are no errors in the logs. Also manually checked each of the imports to make sure that they were all correct and up-to-date. Lastly, I
ran flow in the console within web to ensure that there were no flow-related issues that came out of this change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable