[native] Misc color changes for light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 6:59 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
• abosh
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMf010f0f66936: [native] Misc color changes for light mode

Summary

Misc color changes to make light mode look more consistent with dark mode.

Test Plan

Before:

After:

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-10 at 21.54.21.png (2×1 px, 218 KB)

After:

Things look as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 10 2022, 6:59 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 6:59 PM

atul published this revision for review.Nov 10 2022, 7:00 PM

atul edited the test plan for this revision. (Show Details)

atul mentioned this in D5611: [native] Fix appearance of `TabNavigator` in light mode.

Harbormaster completed remote builds in B13394: Diff 18369.Nov 10 2022, 7:13 PM

atul added inline comments.Nov 10 2022, 9:56 PM

native/themes/colors.js
18 ↗	(On Diff #18369)	(Going to change this)

looks good

This revision is now accepted and ready to land.Nov 11 2022, 8:28 AM

atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:54 AM

This revision now requires review to proceed.Nov 11 2022, 8:54 AM

ashoat accepted this revision.Nov 11 2022, 1:03 PM

This revision is now accepted and ready to land.Nov 11 2022, 1:03 PM

Closed by commit rCOMMf010f0f66936: [native] Misc color changes for light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMf010f0f66936: [native] Misc color changes for light mode.

Revision Contents
Changeset List

Path

Size

native/

navigation/

tab-navigator.react.js

4 lines

themes/

colors.js

20 lines

Diff 18387

View Options

native/navigation/tab-navigator.react.js