[web] Prevent hidden spoiler content from being revealed by text/cursor highlighting
ClosedPublic
Actions

Authored by rohan on Nov 10 2022, 9:58 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMc9f0f74eb02b: [web] Prevent hidden spoiler content from being revealed by text/cursor…

Summary

On web, when a user highlights text with their cursor, we want to prevent 1) the text from being displayed to reveal the spoiler and 2) being copied prior to being revealed.

Linear: https://linear.app/comm/issue/ENG-2227/prevent-hidden-spoiler-content-from-being-revealed-by-textcursor

References:
https://caniuse.com/user-select-none
https://stackoverflow.com/questions/826782/how-to-disable-text-selection-highlighting

Depends on D5601

Test Plan

Tested visually to make sure that the text doesn't reveal on highlight and also made sure the unrevealed spoiler content does not get copied.

Before:

After:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 10 2022, 9:58 PM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 10 2022, 9:58 PM

rohan edited the summary of this revision. (Show Details)Nov 10 2022, 10:00 PM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F232668: Text Highlighting After.mov. (Show Details)

rohan attached a referenced file: F232672: Text Highlighting Before.mov. (Show Details)

rohan edited the summary of this revision. (Show Details)Nov 10 2022, 10:06 PM

rohan added a parent revision: D5601: [web] Reveal the spoiler content on click within a message.

Harbormaster completed remote builds in B13397: Diff 18372.Nov 10 2022, 10:11 PM

rohan requested review of this revision.Nov 10 2022, 10:11 PM

nice thanks for considering all the different platforms/compatibility with them.

Rebase

Harbormaster completed remote builds in B13412: Diff 18396.Nov 11 2022, 5:25 PM

rohan added a child revision: D5623: [web] Make spoiler components block link reveal / click until the spoiler is revealed.Nov 12 2022, 11:40 AM

Appreciate the attention to detail in catching this + thanks for the attached demo videos!

web/markdown/markdown.css
84–87	I think we can probably drop the comments here since the prefixes are pretty ubiquitous, but feel free to keep if you prefer.

This revision is now accepted and ready to land.Nov 14 2022, 5:15 PM

Rebase

Harbormaster completed remote builds in B13436: Diff 18434.Nov 15 2022, 8:25 AM

Closed by commit rCOMMc9f0f74eb02b: [web] Prevent hidden spoiler content from being revealed by text/cursor… (authored by rohan). · Explain WhyNov 16 2022, 9:14 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMc9f0f74eb02b: [web] Prevent hidden spoiler content from being revealed by text/cursor….

Revision Contents
Changeset List

Path

Size

web/

markdown/

markdown.css

5 lines

Diff 18396

View Options

[web] Prevent hidden spoiler content from being revealed by text/cursor highlightingClosedPublicActions