[native] Fix appearance of `Tooltip` in light mode
ClosedPublic
Actions

Authored by atul on Nov 11 2022, 2:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:33 PM

	Unknown Object (File)
	Nov 2 2024, 11:26 PM

	Unknown Object (File)
	Nov 2 2024, 11:26 PM

	Unknown Object (File)
	Nov 2 2024, 11:26 PM

	Unknown Object (File)
	Nov 2 2024, 11:24 PM

View All 60 Files

Subscribers

• abosh

ashoat

Details

Reviewers

tomek
marcin
rohan
ashoat

Commits

rCOMMfa236b17b5f7: [native] Fix appearance of `Tooltip` in light mode

Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Test Plan

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 17.37.03.png (2×1 px, 193 KB)

After:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 17.33.58.png (2×1 px, 193 KB)

Things look as expected (on dark mode as well).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 11 2022, 2:36 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 11 2022, 2:36 PM

atul published this revision for review.Nov 11 2022, 2:37 PM

atul edited the test plan for this revision. (Show Details)

atul added 1 blocking reviewer(s): ginsu.

Harbormaster completed remote builds in B13406: Diff 18390.Nov 11 2022, 2:49 PM

ashoat accepted this revision.Nov 12 2022, 6:41 AM

atul removed a reviewer: ginsu.Nov 14 2022, 7:38 AM

This revision is now accepted and ready to land.Nov 14 2022, 7:38 AM

Closed by commit rCOMMfa236b17b5f7: [native] Fix appearance of `Tooltip` in light mode (authored by atul). · Explain WhyNov 14 2022, 7:39 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfa236b17b5f7: [native] Fix appearance of `Tooltip` in light mode.

Revision Contents
Changeset List

Path

Size

native/

navigation/

tooltip.react.js

28 lines

Diff 18415

View Options

native/navigation/tooltip.react.js

[native] Fix appearance of `Tooltip` in light modeClosedPublicActions