[native] Fix appearance of "Join Chat" in light mode
ClosedPublic
Actions

Authored by atul on Nov 11 2022, 3:18 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
ashoat

Commits

rCOMMb64ff5e82738: [native] Fix appearance of "Join Chat" in light mode

Summary

We actually don't want the color of the text here to change based on theme. Rather it should be determined by the threadColor behind it.

Test Plan

Things look as expected:

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 18.11.52.png (2×1 px, 1 MB)

After:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 18.18.36.png (2×1 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 11 2022, 3:18 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 11 2022, 3:18 PM

atul edited the test plan for this revision. (Show Details)Nov 11 2022, 3:19 PM

pull out common logic to cut repetition

Harbormaster completed remote builds in B13409: Diff 18393.Nov 11 2022, 3:31 PM

atul requested review of this revision.Nov 11 2022, 3:31 PM

Harbormaster completed remote builds in B13408: Diff 18392.Nov 11 2022, 3:32 PM

ashoat accepted this revision.Nov 12 2022, 6:42 AM

This revision is now accepted and ready to land.Nov 12 2022, 6:42 AM

Closed by commit rCOMMb64ff5e82738: [native] Fix appearance of "Join Chat" in light mode (authored by atul). · Explain WhyNov 14 2022, 7:39 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb64ff5e82738: [native] Fix appearance of "Join Chat" in light mode.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

26 lines

Diff 18392

View Options

native/chat/chat-input-bar.react.js

[native] Fix appearance of "Join Chat" in light modeClosedPublicActions