Paths

Table of Contentst

Differential D5658

[keyserver] added target_message to messages table
ClosedPublic
Actions

Authored by ginsu on Nov 16 2022, 6:22 PM.

Tags

None

Referenced Files

	F2834492: D5658.id18547.diff
	Sat, Sep 28, 11:29 AM

	F2834491: D5658.id18545.diff
	Sat, Sep 28, 11:29 AM

	F2834490: D5658.id18508.diff
	Sat, Sep 28, 11:29 AM

	F2834488: D5658.id18507.diff
	Sat, Sep 28, 11:29 AM

	F2834487: D5658.id18541.diff
	Sat, Sep 28, 11:29 AM

	F2834459: D5658.id.diff
	Sat, Sep 28, 11:29 AM

	F2834445: D5658.diff
	Sat, Sep 28, 11:23 AM

	Unknown Object (File)
	Sun, Sep 8, 10:21 PM

Subscribers

Details

Reviewers

atul
tomek
rohan
ashoat

Commits

rCOMMe7ae0af10e88: [keyserver] added target_message to messages table

Summary

added target_message to messages table. target_message is the id of the message that is being reacted to. Also added the index to target_message column and this is to optimize how we will be fetching reaction messages for a certain message

Linear Task: ENG-2265

Test Plan

Please see the screenshot to see that target_message is added to the messages table

Screenshot 2022-11-16 at 9.21.55 PM.png (1×3 px, 1 MB)

Also dropped and created my local DB to test the setup works as expected. Tested the stack locally in my environment to make sure everything still ran as expected/nothing crashed.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 16 2022, 6:22 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptNov 16 2022, 6:22 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2022, 6:25 PM

Harbormaster failed remote builds in B13498: Diff 18507!

rebase

ginsu edited the test plan for this revision. (Show Details)Nov 16 2022, 6:33 PM

ginsu added reviewers: atul, tomek, rohan.

ginsu attached a referenced file: F248488: Screenshot 2022-11-16 at 9.21.55 PM.png. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2022, 6:36 PM

Harbormaster failed remote builds in B13499: Diff 18508!

Harbormaster completed remote builds in B13499: Diff 18508.Nov 16 2022, 6:45 PM

ginsu requested review of this revision.Nov 16 2022, 6:45 PM

Looks good!

(In the future it would be great to put some more context in the Summary section to explain why we're making this change)

This revision is now accepted and ready to land.Nov 16 2022, 8:08 PM

ginsu added a child revision: D5665: [keyserver] add index to target_message column of messages table.Nov 17 2022, 10:18 AM

ginsu mentioned this in D5665: [keyserver] add index to target_message column of messages table.

added index to target_message to messages table

ginsu edited the summary of this revision. (Show Details)Nov 17 2022, 11:47 AM

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13528: Diff 18541.Nov 17 2022, 11:56 AM

ashoat added inline comments.Nov 17 2022, 11:58 AM

keyserver/src/database/migration-config.js
80–91 ↗	(On Diff #18541)	This can be one `dbQuery` with `multipleStatements: true`

made single dbQuery with multipleStatements: true

ashoat accepted this revision.Nov 17 2022, 12:07 PM

Harbormaster completed remote builds in B13531: Diff 18545.Nov 17 2022, 12:19 PM

Closed by commit rCOMMe7ae0af10e88: [keyserver] added target_message to messages table (authored by ginsu). · Explain WhyNov 17 2022, 12:21 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe7ae0af10e88: [keyserver] added target_message to messages table.

ginsu mentioned this in D5747: [keyserver] modified createMessages function to handle inserting targetMessageID into the DB.Nov 29 2022, 7:30 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migration-config.js

15 lines

6 lines

Diff 18545

keyserver/src/database/migration-config.js

Loading...

keyserver/src/database/setup-db.js

Loading...