Paths

Table of Contentst

[native] Fix `Tooltip` color regression
ClosedPublic
Actions

Authored by atul on Nov 17 2022, 5:57 PM.

Details

Reviewers

ginsu
tomek
rohan
varun
marcin
ashoat

Commits

rCOMM4d12f544c844: [native] Fix `Tooltip` color regression

Summary

Context: https://linear.app/comm/issue/ENG-2259/fix-background-color-of-tooltip-in-dark-mode

This diff reverts the background color of the tooltip to #1F1F1F (which had no previous entry in colors.js) for dark mode.

For light mode I just inverted the color to make sure the contrast was similar-ish.

Test Plan

Here's how it looks for

Light mode:

Simulator Screen Shot - Alice - 2022-11-17 at 20.53.03.png (2×1 px, 186 KB)

Dark mode (identical to before):

Simulator Screen Shot - Alice - 2022-11-17 at 20.52.53.png (2×1 px, 183 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 17 2022, 5:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 17 2022, 5:57 PM

atul published this revision for review.Nov 17 2022, 5:58 PM

atul edited the test plan for this revision. (Show Details)

Looks good

This revision is now accepted and ready to land.Nov 17 2022, 6:00 PM

ashoat accepted this revision.Nov 17 2022, 6:01 PM

For good measure here's the Tooltip with "triangle" visible... since I forgot that last time

Harbormaster completed remote builds in B13538: Diff 18555.Nov 17 2022, 6:11 PM

Closed by commit rCOMM4d12f544c844: [native] Fix `Tooltip` color regression (authored by atul). · Explain WhyNov 17 2022, 6:14 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4d12f544c844: [native] Fix `Tooltip` color regression.

Revision Contents
Changeset List

Path

Size

native/

navigation/

tooltip.react.js

6 lines

themes/

colors.js

2 lines

Diff 18556

View Options

native/navigation/tooltip.react.js