I refactored getThreadOtherUsers: changed its name so it matches methods around and
make it return (Relative)MemberInfo's instead of IDs. It was only used in thread-utils.js and
it was easy to changed places where it was called. I need it in that form in typeahead, so I figured
it's fine to extend that function instead of creating another almost identical one.
Details
Details
Tested in furhter diffs.
Visible and works correctly returning all users excluding ashoat and viewer.
Performed sanity check if I didn't break the function (traced one of the functions (getSingleOtherUser) that called it and it performed as expected (in Relationship Prompt))
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please include in the test plan a description of how existing functionality was tested.
Comment Actions
Done. It would be nice to have unit tests covering utility functions like that. Probably will mention it during today's monthly planning.