Paths

Table of Contentst

-
lib/shared/
-
shared/
1/2
mention-utils.js
-
web/chat/
-
chat/
1/2
mention-utils.js

[web] Moved typeahead utils to `web/chat`
ClosedPublic
Actions

Authored by • przemek on Nov 24 2022, 6:11 AM.

Details

Reviewers

tomek
kamil
atul

Commits

rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat`

Summary

Short diff. Moved utils file from lib to web, as it will contain web specific utils.
We might consider keeping common utilites for typeahead in lib, but it can be worked out when
working on native feature.

Test Plan

Functions still visible after changing file locations.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• przemek created this revision.Nov 24 2022, 6:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2022, 6:11 AM

• przemek added a parent revision: D5674: [lib] Added getTextsOffsets function. Refactored mention-utils.js..Nov 24 2022, 6:11 AM

Harbormaster completed remote builds in B13733: Diff 18816.Nov 24 2022, 6:25 AM

• przemek requested review of this revision.Nov 24 2022, 6:25 AM

• przemek added 1 blocking reviewer(s): tomek.Nov 24 2022, 6:28 AM

• przemek added a child revision: D5719: [web] Added more utility functions for typeahead..Nov 24 2022, 7:18 AM

tomek accepted this revision.Nov 24 2022, 8:48 AM

This revision is now accepted and ready to land.Nov 24 2022, 8:48 AM

Rebase

Harbormaster completed remote builds in B13754: Diff 18839.Nov 25 2022, 8:10 AM

Closed by commit rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat` (authored by • przemek). · Explain WhyNov 29 2022, 6:26 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

	web/	chat/
	lib/	shared/

mention-utils.js

8 lines

Diff 18949

View Options

lib/shared/mention-utils.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines