[web] Moved typeahead utils to `web/chat`
ClosedPublic
Actions

Authored by • przemek on Nov 24 2022, 6:11 AM.

Details

Reviewers

tomek
kamil
atul

Commits

rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat`

Summary

Short diff. Moved utils file from lib to web, as it will contain web specific utils.
We might consider keeping common utilites for typeahead in lib, but it can be worked out when
working on native feature.

Test Plan

Functions still visible after changing file locations.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Nov 24 2022, 6:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2022, 6:11 AM

• przemek added a parent revision: D5674: [lib] Added getTextsOffsets function. Refactored mention-utils.js..Nov 24 2022, 6:11 AM

Harbormaster completed remote builds in B13733: Diff 18816.Nov 24 2022, 6:25 AM

• przemek requested review of this revision.Nov 24 2022, 6:25 AM

• przemek added 1 blocking reviewer(s): tomek.Nov 24 2022, 6:28 AM

• przemek added a child revision: D5719: [web] Added more utility functions for typeahead..Nov 24 2022, 7:18 AM

tomek accepted this revision.Nov 24 2022, 8:48 AM

This revision is now accepted and ready to land.Nov 24 2022, 8:48 AM

Rebase

Harbormaster completed remote builds in B13754: Diff 18839.Nov 25 2022, 8:10 AM

Closed by commit rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat` (authored by • przemek). · Explain WhyNov 29 2022, 6:26 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMMe46ae0ec20c2: [web] Moved typeahead utils to `web/chat`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

	web/	chat/
	lib/	shared/

mention-utils.js

8 lines

Diff 18816

View Options

lib/shared/mention-utils.js