Page MenuHomePhabricator

Fix draft store operations
ClosedPublic

Authored by marcin on Nov 28 2022, 4:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 10:09 AM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:16 PM
Unknown Object (File)
Mar 1 2024, 6:21 PM
Unknown Object (File)
Mar 1 2024, 6:21 PM
Unknown Object (File)
Mar 1 2024, 6:20 PM
Subscribers

Details

Summary

Current implementation of draft store operations creation and processing does not obey new policy regarding cancellable asynchronous tasks and tries to access 'payload' property of draft store operation object even if the operation is of type 'remove_all' and does not contain this property. This results in app crashes when logging out.

Test Plan

Build native app on top of https://phab.comm.dev/D5712. Log out - see that app crashes. Apply this differential. See that application does not crash and succesfully logs out.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable