Paths

Table of Contentst

[services][blob] Remove old C++ implementation
ClosedPublic
Actions

Authored by bartek on Nov 30 2022, 7:02 AM.

Details

Reviewers

tomek
• jon
ashoat
varun

Commits

rCOMM288bcb51629a: [services][blob] Remove old C++ implementation

Summary

Removed the services/blob/old directory containing C++ impl

Resolves ENG-2306

Test Plan

CI should not depend on this anymore.
Running and building the service locally runs Rust implementation

Diff Detail

Repository

rCOMM Comm

Branch

barthap/blob-remove-cpp

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 30 2022, 7:02 AM

bartek held this revision as a draft.

Herald added a subscriber: atul. · View Herald TranscriptNov 30 2022, 7:02 AM

Harbormaster completed remote builds in B13881: Diff 19013.Nov 30 2022, 7:12 AM

The CI is passing for the new implementation on master and integration/performance tests are passing so I think we can go on with this one.

ashoat accepted this revision.Dec 1 2022, 8:21 AM

This revision is now accepted and ready to land.Dec 1 2022, 8:21 AM

Closed by commit rCOMM288bcb51629a: [services][blob] Remove old C++ implementation (authored by bartek). · Explain WhyDec 5 2022, 1:30 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM288bcb51629a: [services][blob] Remove old C++ implementation.

Revision Contents
Changeset List

Path

Size

services/

blob/

old/

src/

DatabaseEntities/

MultiPartUploader.cpp

Reactors/

server/

test/

DatabaseManagerTest.cpp

MultiPartUploadTest.cpp

StorageManagerTest.cpp

TestTools.h

TestTools.cpp

Diff 19013

View Options

services/blob/old/CMakeLists.txt

View Options

services/blob/old/src/AwsS3Bucket.h

View Options

services/blob/old/src/AwsS3Bucket.cpp

View Options

services/blob/old/src/BlobServiceImpl.h

View Options

services/blob/old/src/BlobServiceImpl.cpp

View Options

services/blob/old/src/Constants.h

View Options

services/blob/old/src/DatabaseEntities/BlobItem.h

View Options

services/blob/old/src/DatabaseEntities/BlobItem.cpp

View Options

services/blob/old/src/DatabaseEntities/ReverseIndexItem.h

View Options

services/blob/old/src/DatabaseEntities/ReverseIndexItem.cpp

View Options

services/blob/old/src/DatabaseManager.h

View Options

services/blob/old/src/DatabaseManager.cpp

View Options

services/blob/old/src/MultiPartUploader.h

View Options

services/blob/old/src/MultiPartUploader.cpp

View Options

services/blob/old/src/Reactors/server/GetReactor.h

View Options

services/blob/old/src/Reactors/server/PutReactor.h

View Options

services/blob/old/src/S3Path.h

View Options

services/blob/old/src/S3Path.cpp

View Options

services/blob/old/src/S3Tools.h

View Options

services/blob/old/src/S3Tools.cpp

View Options

services/blob/old/src/Tools.h

View Options

services/blob/old/src/Tools.cpp

View Options

services/blob/old/src/server.cpp

View Options

services/blob/old/test/DatabaseManagerTest.cpp

View Options

services/blob/old/test/MultiPartUploadTest.cpp

View Options

services/blob/old/test/StorageManagerTest.cpp

View Options

services/blob/old/test/TestTools.h

View Options

services/blob/old/test/TestTools.cpp

[services][blob] Remove old C++ implementationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19013

services/blob/old/CMakeLists.txt

services/blob/old/src/AwsS3Bucket.h

services/blob/old/src/AwsS3Bucket.cpp

services/blob/old/src/BlobServiceImpl.h

services/blob/old/src/BlobServiceImpl.cpp

services/blob/old/src/Constants.h

services/blob/old/src/DatabaseEntities/BlobItem.h

services/blob/old/src/DatabaseEntities/BlobItem.cpp

services/blob/old/src/DatabaseEntities/ReverseIndexItem.h

services/blob/old/src/DatabaseEntities/ReverseIndexItem.cpp

services/blob/old/src/DatabaseManager.h

services/blob/old/src/DatabaseManager.cpp

services/blob/old/src/MultiPartUploader.h

services/blob/old/src/MultiPartUploader.cpp

services/blob/old/src/Reactors/server/GetReactor.h

services/blob/old/src/Reactors/server/PutReactor.h

services/blob/old/src/S3Path.h

services/blob/old/src/S3Path.cpp

services/blob/old/src/S3Tools.h

services/blob/old/src/S3Tools.cpp

services/blob/old/src/Tools.h

services/blob/old/src/Tools.cpp

services/blob/old/src/server.cpp

services/blob/old/test/DatabaseManagerTest.cpp

services/blob/old/test/MultiPartUploadTest.cpp

services/blob/old/test/StorageManagerTest.cpp

services/blob/old/test/TestTools.h

services/blob/old/test/TestTools.cpp

[services][blob] Remove old C++ implementation
ClosedPublic
Actions

Revision Contents
Changeset List