Page MenuHomePhabricator
Differential D5786

[services][blob] Implement S3Client methods
ClosedPublic
Actions

Authored by bartek on Dec 1 2022, 5:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:44 AM
Unknown Object (File)
Thu, Nov 7, 5:48 AM
Unknown Object (File)
Wed, Nov 6, 11:14 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Tue, Oct 29, 7:54 PM
Unknown Object (File)
Sun, Oct 27, 9:21 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
tomek
Commits
rCOMM12f6b3c72fb3: [services][blob] Implement S3Client methods
Summary

Follow up https://linear.app/comm/issue/ENG-2341/blob-service-create-s3-client-abstraction which follows up https://phab.comm.dev/D5682?id=18592#inline-38028

This diff implements methods in the S3Client struct. It's not yet used anywhere.

Test Plan

Project should still compile. These functions will be tested in the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 1 2022, 5:03 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 1 2022, 5:03 AM
bartek added a parent revision: D5785: [services][blob] Introduce S3 Client abstraction.Dec 1 2022, 5:14 AM
bartek added a child revision: D5787: [services][blob] Use S3 abstraction in service.
Harbormaster completed remote builds in B13913: Diff 19067.Dec 1 2022, 5:15 AM
bartek published this revision for review.Dec 1 2022, 6:04 AM
tomek accepted this revision.Dec 1 2022, 9:54 AM
tomek added inline comments.
services/blob/src/s3.rs
81–95 ↗(On Diff #19067)

Should we specify if the range is inclusive?

• jon accepted this revision.Dec 6 2022, 4:16 PM
varun accepted this revision.Dec 6 2022, 8:02 PM
This revision is now accepted and ready to land.Dec 6 2022, 8:02 PM
bartek updated this revision to Diff 19204.Dec 7 2022, 4:45 AM

Implemented support for RangeBounds. Tested it with integration tests and this playground.

Harbormaster completed remote builds in B14029: Diff 19204.Dec 7 2022, 4:57 AM
Closed by commit rCOMM12f6b3c72fb3: [services][blob] Implement S3Client methods (authored by bartek). · Explain WhyDec 7 2022, 10:37 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM12f6b3c72fb3: [services][blob] Implement S3Client methods.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
52 lines

Diff 19226

View Options

services/blob/src/s3.rs

Loading...