Page MenuHomePhabricator
Differential D5793

[lib] Prevent spoiler text from appearing in notifications
ClosedPublic
Actions

Authored by rohan on Dec 1 2022, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:52 AM
Unknown Object (File)
Sat, Nov 9, 11:50 AM
Unknown Object (File)
Sat, Nov 9, 11:50 AM
Unknown Object (File)
Sat, Nov 9, 11:49 AM
Unknown Object (File)
Thu, Nov 7, 7:22 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Oct 7 2024, 12:10 PM
Unknown Object (File)
Oct 4 2024, 8:40 AM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
ashoat
Commits
rCOMMf0e26cd283c1: [lib] Prevent spoiler text from appearing in notifications
Summary

We want to hide spoilers from notifications on both iOS and Android. The context / discussion is on the Linear task:
https://linear.app/comm/issue/ENG-2056/prevent-spoiler-text-from-appearing-in-notifications-[native]

Test Plan

Testing for both iOS and Android will be included once I can link screenshots here.

  1. This is a default message

iOS

[B][iOS] Default.png (2×1 px, 3 MB)

[A][iOS] Default.png (2×1 px, 3 MB)

Android
[B][Android] Default.png (1×1 px, 483 KB)

[A][Android] Default.png (1×1 px, 483 KB)

  1. This is a text with ||spoilers||

iOS

[B][iOS] One Spoiler.png (2×1 px, 3 MB)

[A][iOS] One Spoiler.png (2×1 px, 3 MB)

Android
[B][Android] One Spoiler.png (1×1 px, 484 KB)

[A][Android] One Spoiler.png (1×1 px, 483 KB)

  1. ||One|| and ||Two|| and Three

iOS

[B][iOS] Multiple Spoilers.png (2×1 px, 3 MB)

[A][iOS] Multiple Spoilers.png (2×1 px, 3 MB)

Android
[B][Android] Multiple Spoilers.png (1×1 px, 483 KB)

[A][Android] Multiple Spoilers.png (1×1 px, 481 KB)

  1. ||Bold Text||

iOS

[B][iOS] Bold Spoiler.png (2×1 px, 3 MB)

[A][iOS] Bold Spoiler.png (2×1 px, 3 MB)

Android
[B][Android] Bold Spoiler.png (1×1 px, 482 KB)

[A][Android] Bold Spoilers.png (1×1 px, 478 KB)

Diff Detail

Repository
rCOMM Comm
Branch
notifications_spoilers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Dec 1 2022, 1:28 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2022, 1:28 PM
rohan edited the test plan for this revision. (Show Details)Dec 1 2022, 1:33 PM
rohan attached a referenced file: F268767: [A][Android] Bold Spoilers.png. (Show Details)
rohan attached a referenced file: F268766: [B][Android] Bold Spoiler.png. (Show Details)
rohan attached a referenced file: F268765: [A][iOS] Bold Spoiler.png. (Show Details)
rohan attached a referenced file: F268764: [B][iOS] Bold Spoiler.png. (Show Details)
rohan attached a referenced file: F268763: [A][Android] Multiple Spoilers.png. (Show Details)
rohan attached a referenced file: F268762: [B][Android] Multiple Spoilers.png. (Show Details)
rohan attached a referenced file: F268761: [A][iOS] Multiple Spoilers.png. (Show Details)
rohan attached a referenced file: F268760: [B][iOS] Multiple Spoilers.png. (Show Details)
Harbormaster completed remote builds in B13921: Diff 19077.Dec 1 2022, 1:41 PM
rohan requested review of this revision.Dec 1 2022, 1:41 PM
rohan edited the test plan for this revision. (Show Details)Dec 1 2022, 1:42 PM
ashoat accepted this revision.Dec 1 2022, 2:51 PM
ashoat removed 1 blocking reviewer(s): atul.
This revision is now accepted and ready to land.Dec 1 2022, 2:51 PM
Closed by commit rCOMMf0e26cd283c1: [lib] Prevent spoiler text from appearing in notifications (authored by rohan). · Explain WhyDec 1 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMMf0e26cd283c1: [lib] Prevent spoiler text from appearing in notifications.

Revision Contents
Changeset List

PathSize
lib/
shared/
6 lines
messages/
17 lines

Diff 19077

View Options

lib/shared/markdown.js

Loading...
View Options

lib/shared/messages/text-message-spec.js

Loading...