[native] Remove ignoreLogs for Reanimated warning
ClosedPublic
Actions

Authored by ashoat on Dec 20 2022, 1:41 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM2905b616b30b: [native] Remove ignoreLogs for Reanimated warning

Summary

The warning doesn't seem to occur anymore, so we can remove this ignoreLogs call!

The ignoreLogs call was first added in D185. Context on this diff is here.

Test Plan

Open up the inbox, then open up a chat, and then go back. This should cause many Animated nodes to mount/unmount, which would previously have triggered this warning. I tested on both an iOS physical device and an Android emulator.

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/rea_warning

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 20 2022, 1:41 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 20 2022, 1:41 PM

ashoat mentioned this in D5935: [native] [34/40] RN 0.70: Update to react-native-gesture-handler@2.8.0.Dec 20 2022, 1:42 PM

Harbormaster completed remote builds in B14585: Diff 19891.Dec 20 2022, 1:54 PM

ashoat requested review of this revision.Dec 20 2022, 1:54 PM

bartek accepted this revision.Dec 20 2022, 11:24 PM

This revision is now accepted and ready to land.Dec 20 2022, 11:24 PM

tomek accepted this revision.Dec 21 2022, 4:02 AM

Closed by commit rCOMM2905b616b30b: [native] Remove ignoreLogs for Reanimated warning (authored by ashoat). · Explain WhyDec 21 2022, 7:35 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2905b616b30b: [native] Remove ignoreLogs for Reanimated warning.

Revision Contents
Changeset List

Path

Size

native/

root.react.js

7 lines

Diff 19891

View Options

native/root.react.js

	Show All 10 Lines
	import type { AppState } from '../redux/state-types.js';			import type { AppState } from '../redux/state-types.js';
	import type { NavPlusRedux } from '../types/selector-types.js';			import type { NavPlusRedux } from '../types/selector-types.js';

	const msInHour = 60 * 60 * 1000;			const msInHour = 60 * 60 * 1000;

	const nextMessagePruneTimeSelector: (state: AppState) => ?number =			const nextMessagePruneTimeSelector: (state: AppState) => ?number =
	createSelector(			createSelector(
	(state: AppState) => state.messageStore.threads,			(state: AppState) => state.messageStore.threads,
	(threadMessageInfos: { +[id: string]: ThreadMessageInfo }): ?number => {			(state: AppState) => state.threadActivityStore,
				(
				threadMessageInfos: { +[id: string]: ThreadMessageInfo },
				threadActivityStore: ThreadActivityStore,
				): ?number => {
	let nextTime;			let nextTime;
	for (const threadID in threadMessageInfos) {			for (const threadID in threadMessageInfos) {
	const threadMessageInfo = threadMessageInfos[threadID];
	const threadPruneTime = Math.max(			const threadPruneTime = Math.max(
	threadMessageInfo.lastNavigatedTo + msInHour,			(threadActivityStore?.[threadID]?.lastNavigatedTo ?? 0) + msInHour,
	threadMessageInfo.lastPruned + msInHour * 6,			(threadActivityStore?.[threadID]?.lastPruned ?? 0) + msInHour * 6,
	);			);
	if (nextTime === undefined \|\| threadPruneTime < nextTime) {			if (nextTime === undefined \|\| threadPruneTime < nextTime) {
	nextTime = threadPruneTime;			nextTime = threadPruneTime;
	}			}
	}			}
	return nextTime;			return nextTime;
	},			},
	);			);
	Show All 33 Lines

[native] Remove ignoreLogs for Reanimated warningClosedPublicActions