Page MenuHomePhabricator
Differential D5982

[keyserver] Fix JSONStream types
ClosedPublic
Actions

Authored by ashoat on Dec 21 2022, 8:21 PM.
Tags
None
Referenced Files
F3517597: D5982.diff
Sun, Dec 22, 5:50 PM
Unknown Object (File)
Wed, Dec 4, 12:32 PM
Unknown Object (File)
Wed, Dec 4, 12:31 PM
Unknown Object (File)
Wed, Dec 4, 12:31 PM
Unknown Object (File)
Wed, Dec 4, 12:30 PM
Unknown Object (File)
Wed, Dec 4, 12:30 PM
Unknown Object (File)
Wed, Dec 4, 12:30 PM
Unknown Object (File)
Wed, Dec 4, 12:09 PM
View All Files
Subscribers
None

Details

Reviewers
ginsu
michal
atul
tomek
Commits
rCOMMbd7f7f93fda0: [keyserver] Fix JSONStream types
Summary

No need to talk explicitly about Promises here... ultimately it's a mixed type.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 21 2022, 8:21 PM
ashoat added a child revision: D5983: [web] Only render Loading component in SSR.Dec 21 2022, 8:23 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 21 2022, 8:25 PM
Harbormaster failed remote builds in B14652: Diff 19988!
ashoat updated this revision to Diff 19993.Dec 21 2022, 8:40 PM

Rebase

ashoat removed a child revision: D5983: [web] Only render Loading component in SSR.Dec 21 2022, 8:41 PM
ashoat edited parent revisions, added: D5983: [web] Only render Loading component in SSR; removed: D5981: [web] Introduce Loading component to web.
ashoat added a child revision: D5984: [web] Remove timeZone from Redux state.
ashoat edited the summary of this revision. (Show Details)
ashoat updated this revision to Diff 19997.Dec 21 2022, 8:49 PM

Rebase

Harbormaster completed remote builds in B14657: Diff 19993.Dec 21 2022, 8:54 PM
Harbormaster completed remote builds in B14661: Diff 19997.Dec 21 2022, 9:03 PM
ashoat requested review of this revision.Dec 21 2022, 9:03 PM
tomek accepted this revision.Dec 22 2022, 8:12 AM
tomek added inline comments.
keyserver/src/utils/json-stream.js
8–10

input is the only place where type parameter is used so maybe we can make this an ordinary function (non-generic)?

This revision is now accepted and ready to land.Dec 22 2022, 8:12 AM
ginsu accepted this revision.Dec 22 2022, 10:12 AM
michal accepted this revision.Dec 22 2022, 10:34 AM
ashoat updated this revision to Diff 20049.Dec 22 2022, 6:23 PM

Get rid of unnecessary type params

Harbormaster failed remote builds in B14706: Diff 20049!Dec 22 2022, 6:37 PM
Harbormaster completed remote builds in B14706: Diff 20049.Dec 22 2022, 6:55 PM
Closed by commit rCOMMbd7f7f93fda0: [keyserver] Fix JSONStream types (authored by ashoat). · Explain WhyDec 22 2022, 6:58 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMbd7f7f93fda0: [keyserver] Fix JSONStream types.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines
utils/
5 lines

Diff 19997

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

keyserver/src/utils/json-stream.js

Loading...