Page MenuHomePhabricator
Differential D5983

[web] Only render Loading component in SSR
ClosedPublic
Actions

Authored by ashoat on Dec 21 2022, 8:23 PM.
Tags
None
Referenced Files
F3523267: D5983.diff
Mon, Dec 23, 8:50 AM
Unknown Object (File)
Thu, Dec 12, 4:12 PM
Unknown Object (File)
Wed, Dec 4, 12:30 PM
Unknown Object (File)
Wed, Dec 4, 12:29 PM
Unknown Object (File)
Wed, Dec 4, 12:29 PM
Unknown Object (File)
Wed, Dec 4, 12:28 PM
Unknown Object (File)
Wed, Dec 4, 12:28 PM
Unknown Object (File)
Wed, Dec 4, 12:08 PM
View All Files
Subscribers
None

Details

Reviewers
ginsu
michal
atul
tomek
Commits
rCOMM20974d4942a2: [web] Only render Loading component in SSR
Summary

This addresses ENG-2513. Now that the web app needs to wait on redux-persist before hiding Loading, all we need to render on the SSR side is Loading.

Test Plan

Load the site in both dev and prod modes and make sure there are no warnings about SSR not aligning with client-side rendering, and that there is no "double-render" effect

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 21 2022, 8:23 PM
ashoat added a child revision: D5984: [web] Remove timeZone from Redux state.
Harbormaster completed remote builds in B14653: Diff 19989.Dec 21 2022, 8:37 PM
ashoat requested review of this revision.Dec 21 2022, 8:37 PM
ashoat updated this revision to Diff 19992.Dec 21 2022, 8:40 PM

Rebase

ashoat edited parent revisions, added: D5981: [web] Introduce Loading component to web; removed: D5982: [keyserver] Fix JSONStream types.Dec 21 2022, 8:41 PM
ashoat added a child revision: D5982: [keyserver] Fix JSONStream types.
ashoat removed a child revision: D5984: [web] Remove timeZone from Redux state.
ashoat edited the summary of this revision. (Show Details)
Harbormaster failed remote builds in B14656: Diff 19992!Dec 21 2022, 8:43 PM
ashoat updated this revision to Diff 19996.Dec 21 2022, 8:48 PM

Silence Flow until the next diff

keyserver/src/responders/website-responders.js
312 ↗(On Diff #19996)

any removed in subsequent diff

Harbormaster completed remote builds in B14660: Diff 19996.Dec 21 2022, 9:02 PM
tomek accepted this revision.Dec 22 2022, 8:15 AM
This revision is now accepted and ready to land.Dec 22 2022, 8:15 AM
ginsu accepted this revision.Dec 22 2022, 10:10 AM
michal accepted this revision.Dec 22 2022, 10:32 AM
Closed by commit rCOMM20974d4942a2: [web] Only render Loading component in SSR (authored by ashoat). · Explain WhyDec 22 2022, 6:58 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM20974d4942a2: [web] Only render Loading component in SSR.
inka mentioned this in D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.Feb 23 2024, 3:03 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
62 lines
web/
2 lines

Diff 19992

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

web/webpack.config.cjs

Loading...