[keyserver] Introduce `isValidEthereumAddress`
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM4c73fbabf863: [keyserver] Introduce `isValidEthereumAddress`

Summary

Simple RegEx sanity check to ensure that the address is a well formed ethereum address.

~~Use utility in siweAuthResponder to throw a ServerError if address fails isValidEthereumAddress check.~~ (Will be used in isValidSIWEMessage instead.)

Depends on D6028

Test Plan

Unit tests and tried calling endpoint with correct and incorrectly formed addresses.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM

atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM

atul added a parent revision: D6028: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is signed.

atul added a child revision: D6030: [lib] Introduce `SIWEMessage` type.

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B14739: Diff 20103.Dec 24 2022, 8:13 PM

atul requested review of this revision.Dec 24 2022, 8:13 PM

ashoat accepted this revision.Dec 25 2022, 7:24 PM

This revision is now accepted and ready to land.Dec 25 2022, 7:24 PM

atul retitled this revision from [keyserver] Introduce `isValidEthereumAddress` and use it to validate `address` in `siweAuthResponder` to [keyserver] Introduce `isValidEthereumAddress`.Dec 27 2022, 12:42 AM

atul edited the summary of this revision. (Show Details)

address feedback

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:45 AM

Closed by commit rCOMM4c73fbabf863: [keyserver] Introduce `isValidEthereumAddress` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4c73fbabf863: [keyserver] Introduce `isValidEthereumAddress`.

Harbormaster completed remote builds in B14761: Diff 20134.Dec 27 2022, 12:58 AM