[CI] Fix "ESLint & Flow & Jest" workflow.
ClosedPublic
Actions

Authored by atul on Dec 27 2022, 1:13 AM.

Details

Reviewers

tomek
marcin
varun
ginsu

Commits

rCOMM077249b848d6: [CI] Fix "ESLint & Flow & Jest" workflow.

Summary

Experienced the same isue described in https://linear.app/comm/issue/ENG-2505/investigate-why-buildkite-ci-didnt-pick-up-eslint-issues

with the following: https://buildkite.com/comm/eslint-and-flow-and-jest/builds/4877#018552b3-4a50-487d-8e70-c6fd7d8c9e65

where issues were logged but workflows didn't fail: https://blob.sh/e7ff64.png

Test Plan

local testing to make sure errors are deterministically caught

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 27 2022, 1:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 27 2022, 1:13 AM

atul published this revision for review.Dec 27 2022, 1:14 AM

Harbormaster failed remote builds in B14769: Diff 20147!Dec 27 2022, 1:26 AM

Harbormaster completed remote builds in B14769: Diff 20147.Dec 27 2022, 3:00 AM

tomek accepted this revision.Dec 27 2022, 5:34 AM

This revision is now accepted and ready to land.Dec 27 2022, 5:34 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 6:31 PM

Closed by commit rCOMM077249b848d6: [CI] Fix "ESLint & Flow & Jest" workflow. (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM077249b848d6: [CI] Fix "ESLint & Flow & Jest" workflow..

Harbormaster completed remote builds in B14810: Diff 20199.Dec 27 2022, 6:39 PM

Revision Contents
Changeset List

Path

Size

.buildkite/

eslint_flow_jest.yml

2 lines

Diff 20200

View Options

.buildkite/eslint_flow_jest.yml

[CI] Fix "ESLint & Flow & Jest" workflow.ClosedPublicActions