Update native CMake logic to include addition of the
native_rust_library and another react-native header.
The native modules needs to be references as a CMake target
to avoid usage of GLOB_RECURSIVE in our Android build.
Details
Details
- Reviewers
varun • max bartek - Commits
- rCOMM00fd77a404ef: [Native] Fix native modules CMake build
cd native/cpp/CommonCpp/ rm -rf build && mkdir build && cd build && cmake .. && make -j
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/fix-native-modules
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
We're moving these out from native/android/app/CMakeLists.txt, yeah? It might make review easier if you try to find a way you can do the additions and removals in the same diff – then it becomes easier to grok what's going on as a reviewer. Not always possible though
Comment Actions
We're moving these out from native/android/app/CMakeLists.txt, yeah?
Correct, mention it in the second part of the summary.
It might make review easier if you try to find a way you can do the additions and removals in the same diff – then it becomes easier to grok what's going on as a reviewer. Not always possible though
It's going to be quite large if I do that. I would really like to avoid having 100+ line diffs which no one wants to review.
Comment Actions
This compiles for me
| native/cpp/CommonCpp/NativeModules/CMakeLists.txt | ||
|---|---|---|
| 4–5 | Could this comment be added here? I was wondering why we need the CMAKE_OSX_DEPLOYMENT_TARGET and finally found this comment in our other CMake files. | |