Page MenuHomePhabricator
Differential D6115

[native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 3:41 PM
Unknown Object (File)
Fri, Apr 18, 10:41 AM
Unknown Object (File)
Fri, Apr 18, 1:09 AM
Unknown Object (File)
Thu, Apr 17, 11:19 AM
Unknown Object (File)
Wed, Apr 9, 6:04 AM
Unknown Object (File)
Fri, Apr 4, 6:35 PM
Unknown Object (File)
Mar 8 2025, 6:51 PM
Unknown Object (File)
Feb 17 2025, 9:05 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM331e51b88036: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`
Summary

Right now getUserPublicKey() returns stringified JSON, we want an object of type ClientPublicKeys instead.

Test Plan

Added the following to privacy-preferences.react.js and logged values to ensure that they were as expected:

React.useEffect(() => {
  (async () => {
    await commCoreModule.initializeCryptoAccount('ABC');
    const { curve25519, ed25519 } = await commCoreModule.getUserPublicKey();
    console.log(curve25519);
    console.log(ed25519);
  })();
}, []);

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
13 lines
schema/
7 lines

Diff 20453

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

native/schema/CommCoreModuleSchema.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines