Paths

Table of Contentst

-
keyserver/src/responders/
-
src/
-
responders/
-
landing-handler.js

Differential D6126

[keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder` response
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 6:19 PM.

Tags

None

Referenced Files

	F5890553: D6126.id20471.diff
	Thu, Apr 17, 6:13 AM

	F5889836: D6126.id20475.diff
	Thu, Apr 17, 5:26 AM

	Unknown Object (File)
	Thu, Apr 17, 12:03 AM

	Unknown Object (File)
	Wed, Apr 16, 8:41 PM

	Unknown Object (File)
	Wed, Apr 16, 3:36 PM

	Unknown Object (File)
	Wed, Apr 9, 6:05 AM

	Unknown Object (File)
	Tue, Apr 8, 10:28 PM

	Unknown Object (File)
	Mar 2 2025, 9:55 AM

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMM3b4a290c6640: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder`…

Summary

Include siwePrimaryIdentityPublicKey in landingResponder the same way we included siweNonce.

In subsequent diff the Context will be updated to consume (and make available to SIWE component) the value passed in here.

Depends on D6125

Test Plan

Will be tested implicitly by subsequent diffs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 30 2022, 6:19 PM

atul edited the summary of this revision. (Show Details)Dec 30 2022, 6:20 PM

atul added a parent revision: D6125: [lib] Introduce `isValidPrimaryIdentityPublicKey`.

Harbormaster completed remote builds in B14995: Diff 20468.Dec 30 2022, 6:34 PM

atul requested review of this revision.Dec 30 2022, 6:34 PM

ashoat accepted this revision.Dec 30 2022, 8:55 PM

This revision is now accepted and ready to land.Dec 30 2022, 8:55 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 30 2022, 9:20 PM

Closed by commit rCOMM3b4a290c6640: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3b4a290c6640: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder`….

Harbormaster completed remote builds in B14998: Diff 20471.Dec 30 2022, 9:30 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

landing-handler.js

24 lines

Diff 20475

keyserver/src/responders/landing-handler.js

	Show All 13 Lines
	target_link_libraries(comm-client			target_link_libraries(comm-client
	comm-modules-native			comm-modules-native
	)			)

	target_link_libraries(comm-cryptotools			target_link_libraries(comm-cryptotools
	comm-tools			comm-tools
	comm-databasemanagers			comm-databasemanagers
	)			)

				target_link_libraries(comm-modules-internal
				comm-tools
				comm-client
				)

				target_link_libraries(comm-modules-native
				comm-client
				comm-cryptotools
				comm-databasemanagers
				comm-tools
				)

				target_link_libraries(comm-modules-persistentstorage
				comm-databasemanagers
				comm-client
				)