[native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 3:23 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM331e51b88036: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`

Summary

Right now getUserPublicKey() returns stringified JSON, we want an object of type ClientPublicKeys instead.

Test Plan

Added the following to privacy-preferences.react.js and logged values to ensure that they were as expected:

React.useEffect(() => {
  (async () => {
    await commCoreModule.initializeCryptoAccount('ABC');
    const { curve25519, ed25519 } = await commCoreModule.getUserPublicKey();
    console.log(curve25519);
    console.log(ed25519);
  })();
}, []);

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 30 2022, 3:23 PM

atul published this revision for review.Dec 30 2022, 3:24 PM

Harbormaster completed remote builds in B14984: Diff 20453.Dec 30 2022, 3:38 PM

atul added a child revision: D6124: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`.Dec 30 2022, 6:02 PM

ashoat accepted this revision.Dec 30 2022, 8:57 PM

This revision is now accepted and ready to land.Dec 30 2022, 8:57 PM

Closed by commit rCOMM331e51b88036: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys` (authored by atul). · Explain WhyDec 30 2022, 9:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM331e51b88036: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`.

ashoat mentioned this in D6822: Sign concatenation of public and notif keypairs using private key of public identity.Mar 6 2023, 10:53 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

13 lines

schema/

CommCoreModuleSchema.js

7 lines

Diff 20472

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp