Page MenuHomePhabricator
Differential D6125

[lib] Introduce `isValidPrimaryIdentityPublicKey`
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2025, 8:24 PM
Unknown Object (File)
Feb 17 2025, 9:07 PM
Unknown Object (File)
Feb 17 2025, 9:07 PM
Unknown Object (File)
Feb 17 2025, 9:07 PM
Unknown Object (File)
Feb 15 2025, 11:30 PM
Unknown Object (File)
Feb 13 2025, 10:12 AM
Unknown Object (File)
Feb 13 2025, 10:12 AM
Unknown Object (File)
Feb 13 2025, 10:12 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey`
Summary

Going to use this in landing-handler to validate siwe-primary-identity-public-key header value before "injecting" into page.

Depends on D6124

Test Plan

unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 30 2022, 6:03 PM
atul added inline comments.Dec 30 2022, 6:07 PM
lib/utils/siwe-utils.js
16 ↗(On Diff #20467)

43 "base64 alphabet" characters, uses + and / instead of - and _ based on the following key I generated: 98+/eB2MUVvYCpkESOS1zuWnWttsYWDKeDXl8T3o8LY

atul published this revision for review.Dec 30 2022, 6:08 PM
Harbormaster completed remote builds in B14994: Diff 20467.Dec 30 2022, 6:17 PM
atul added a child revision: D6126: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder` response.Dec 30 2022, 6:20 PM
ashoat accepted this revision.Dec 30 2022, 8:55 PM
This revision is now accepted and ready to land.Dec 30 2022, 8:55 PM
atul updated this revision to Diff 20470.Dec 30 2022, 9:16 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 30 2022, 9:20 PM
Closed by commit rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey`.
Harbormaster completed remote builds in B14997: Diff 20470.Dec 30 2022, 9:30 PM

Revision Contents
Changeset List

PathSize
lib/
utils/
6 lines
24 lines

Diff 20474

View Options

lib/utils/siwe-utils.js

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines
View Options

lib/utils/siwe-utils.test.js

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines