[lib] Introduce `isValidPrimaryIdentityPublicKey`
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 6:03 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey`

Summary

Going to use this in landing-handler to validate siwe-primary-identity-public-key header value before "injecting" into page.

Depends on D6124

Test Plan

unit tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 30 2022, 6:03 PM

atul added inline comments.Dec 30 2022, 6:07 PM

lib/utils/siwe-utils.js
16 ↗	(On Diff #20467)	43 "base64 alphabet" characters, uses `+` and `/` instead of `-` and `_` based on the following key I generated: `98+/eB2MUVvYCpkESOS1zuWnWttsYWDKeDXl8T3o8LY`

atul published this revision for review.Dec 30 2022, 6:08 PM

Harbormaster completed remote builds in B14994: Diff 20467.Dec 30 2022, 6:17 PM

atul added a child revision: D6126: [keyserver] Include `siwePrimaryIdentityPublicKey` in `landingResponder` response.Dec 30 2022, 6:20 PM

ashoat accepted this revision.Dec 30 2022, 8:55 PM

This revision is now accepted and ready to land.Dec 30 2022, 8:55 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 30 2022, 9:20 PM

Closed by commit rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM423fcb8e9658: [lib] Introduce `isValidPrimaryIdentityPublicKey`.

Harbormaster completed remote builds in B14997: Diff 20470.Dec 30 2022, 9:30 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

siwe-utils.js

6 lines

siwe-utils.test.js

24 lines

Diff 20470

View Options

lib/utils/siwe-utils.js